Skip to content

ci: skip general tests for isolated changes - #11692

Merged
markijbema merged 4 commits into
mainfrom
mark/skip-general-tests-for-jetbrains
Jun 26, 2026
Merged

ci: skip general tests for isolated changes#11692
markijbema merged 4 commits into
mainfrom
mark/skip-general-tests-for-jetbrains

Conversation

@markijbema

@markijbema markijbema commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Skip the general cross-platform unit suite when a pull request changes only isolated product, documentation, or repository metadata files. This avoids running unrelated CLI tests for JetBrains, VS Code, docs, Zed, changeset-only, specification, and other non-runtime changes.

The filter is deliberately allowlisted: shared packages, dependency and build configuration, active workflows, scripts, and unknown paths continue to run the full Linux, macOS, and Windows matrix. Manual runs and changes outside pull requests also retain the full suite.

A lightweight Linux no-op entry preserves the existing required unit (linux) check when the general suite is skipped.

…-only changes

Add a `changes` job that uses `paths-filter` to detect if changes are
restricted to the `packages/kilo-jetbrains/` directory. The `unit` job
is updated to depend on this job and uses a dynamic matrix to skip
execution on non-JetBrains platforms when only JetBrains files are
modified, optimizing CI runtime.

Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Comment thread .github/workflows/test.yml Outdated
@kilo-code-bot

kilo-code-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • .github/workflows/test.yml
Previous Review Summaries (3 snapshots, latest commit 7b13837)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 7b13837)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • .github/workflows/test.yml

Previous review (commit 8d449df)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • .github/workflows/test.yml

Previous review (commit 376398e)

Status: 1 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0

Fix these issues in Kilo Cloud

Issue Details (click to expand)

WARNING

File Line Issue
.github/workflows/test.yml 52 The new GENERAL guard also skips the full unit matrix on push to main for JetBrains-only merges, even though the change is described as PR-only.
Files Reviewed (1 files)
  • .github/workflows/test.yml - 1 issue

Reviewed by gpt-5.4-20260305 · Input: 37.1K · Output: 6.3K · Cached: 198.4K

Review guidance: REVIEW.md from base branch main

markijbema and others added 2 commits June 25, 2026 12:59
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
@markijbema markijbema changed the title ci: skip general tests for JetBrains-only changes ci: skip general tests for isolated changes Jun 26, 2026
Comment thread .github/workflows/test.yml Outdated
- '!.github/CODEOWNERS'
- '!.github/pull_request_template.md'
- '!.github/workflows/disabled/**'
- '!.idea/**'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything from here on seems a bit too much

@markijbema
markijbema enabled auto-merge June 26, 2026 13:37
@markijbema
markijbema merged commit c9d7016 into main Jun 26, 2026
25 checks passed
@markijbema
markijbema deleted the mark/skip-general-tests-for-jetbrains branch June 26, 2026 18:43
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
…ts-for-jetbrains

ci: skip general tests for isolated changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants