fix(vscode): exclude .cli-version marker from VSIX packaging - #11660
Merged
Conversation
The .cli-version file written by local-bin.ts during both dev (compile) and production (package) builds was shipped in the VSIX because .vscodeignore re-includes bin/**. That made the localCli branch in ServerManager true for production installs, letting resolveLocalBwrapEnv inject KILO_BWRAP_PATH from ~/.cache/kilo-vscode/bwrap whenever the bundled helper looked incomplete — broader than the intended dev-only fallback. Exclude the build-only marker after the !bin/** re-include so it stays present in local source/dev checkouts but is absent from packaged installs, keeping localCli detection truly local-only.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.4-2026-03-05 · Input: 59.5K · Output: 8.1K · Cached: 201.9K Review guidance: REVIEW.md from base branch |
marius-kilocode
approved these changes
Jun 24, 2026
NJ-2020
pushed a commit
to NJ-2020/kilocode
that referenced
this pull request
Jul 4, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
…n-marker-packaging fix(vscode): exclude .cli-version marker from VSIX packaging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Exclude the build-only
bin/.cli-versionmarker from the packaged VSIX so production installs are no longer detected as local builds.Why
local-bin.tswritesbin/.cli-versionduring both dev (compile) and production (package) builds..vscodeignorere-includesbin/**so the CLI binary ships, which also ships.cli-version. That made thelocalClibranch inServerManager.startServertrue outside F5 sessions:As a result, production installs could inject
KILO_BWRAP_PATHfrom~/.cache/kilo-vscode/bwrapwhenever the bundled helper looked incomplete — broader than the local-only fallback this code intended to add.How
Add
bin/.cli-versionto.vscodeignoreafter the!bin/**re-include. The marker stays present in local source/dev checkouts (so source runs still work) but is absent from packaged installs, keepinglocalClidetection truly local-only. All runtimebin/artifacts (kilo,bwrap,tree-sitter/**,licenses/**, the sandbox worker) still ship — verified against theignorelibraryvsceuses.This is a packaging-only change; no runtime code is touched.