Skip to content

fix(vscode): exclude .cli-version marker from VSIX packaging - #11660

Merged
catrielmuller merged 1 commit into
mainfrom
fix/vscode-cli-version-marker-packaging
Jun 24, 2026
Merged

fix(vscode): exclude .cli-version marker from VSIX packaging#11660
catrielmuller merged 1 commit into
mainfrom
fix/vscode-cli-version-marker-packaging

Conversation

@catrielmuller

Copy link
Copy Markdown
Contributor

What

Exclude the build-only bin/.cli-version marker from the packaged VSIX so production installs are no longer detected as local builds.

Why

local-bin.ts writes bin/.cli-version during both dev (compile) and production (package) builds. .vscodeignore re-includes bin/** so the CLI binary ships, which also ships .cli-version. That made the localCli branch in ServerManager.startServer true outside F5 sessions:

const localCli =
  this.context.extensionMode === vscode.ExtensionMode.Development ||
  fs.existsSync(path.join(this.context.extensionPath, "bin", ".cli-version"))
const bwrapEnv = process.env.KILO_BWRAP_PATH ? {} : resolveLocalBwrapEnv(this.context.extensionPath, localCli)

As a result, production installs could inject KILO_BWRAP_PATH from ~/.cache/kilo-vscode/bwrap whenever the bundled helper looked incomplete — broader than the local-only fallback this code intended to add.

How

Add bin/.cli-version to .vscodeignore after the !bin/** re-include. The marker stays present in local source/dev checkouts (so source runs still work) but is absent from packaged installs, keeping localCli detection truly local-only. All runtime bin/ artifacts (kilo, bwrap, tree-sitter/**, licenses/**, the sandbox worker) still ship — verified against the ignore library vsce uses.

This is a packaging-only change; no runtime code is touched.

The .cli-version file written by local-bin.ts during both dev (compile)
and production (package) builds was shipped in the VSIX because
.vscodeignore re-includes bin/**. That made the localCli branch in
ServerManager true for production installs, letting resolveLocalBwrapEnv
inject KILO_BWRAP_PATH from ~/.cache/kilo-vscode/bwrap whenever the
bundled helper looked incomplete — broader than the intended dev-only
fallback.

Exclude the build-only marker after the !bin/** re-include so it stays
present in local source/dev checkouts but is absent from packaged
installs, keeping localCli detection truly local-only.
@kilo-code-bot

kilo-code-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • .changeset/vscode-cli-version-marker-packaging.md
  • packages/kilo-vscode/.vscodeignore

Reviewed by gpt-5.4-2026-03-05 · Input: 59.5K · Output: 8.1K · Cached: 201.9K

Review guidance: REVIEW.md from base branch main

@catrielmuller
catrielmuller merged commit e000cbe into main Jun 24, 2026
24 checks passed
@catrielmuller
catrielmuller deleted the fix/vscode-cli-version-marker-packaging branch June 24, 2026 20:17
NJ-2020 pushed a commit to NJ-2020/kilocode that referenced this pull request Jul 4, 2026
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
…n-marker-packaging

fix(vscode): exclude .cli-version marker from VSIX packaging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants