Skip to content

fix(vscode): bundle local bwrap helper - #11657

Merged
catrielmuller merged 1 commit into
mainfrom
fix/vscode-local-bwrap-bundle
Jun 24, 2026
Merged

fix(vscode): bundle local bwrap helper#11657
catrielmuller merged 1 commit into
mainfrom
fix/vscode-local-bwrap-bundle

Conversation

@catrielmuller

Copy link
Copy Markdown
Contributor

Local source-wrapper VS Code dev launches run the CLI through Bun, so a Bubblewrap helper beside bin/kilo is not discovered through process.execPath.

This stages a verified Bubblewrap helper in the user cache and passes KILO_BWRAP_PATH only for local/dev CLI launches when a complete production helper is absent. Production bundled helpers and explicit user KILO_BWRAP_PATH overrides keep their existing behavior.

@catrielmuller
catrielmuller enabled auto-merge June 24, 2026 17:47
const indexingEnv = resolveIndexingEnv(folders)
const localCli =
this.context.extensionMode === vscode.ExtensionMode.Development ||
fs.existsSync(path.join(this.context.extensionPath, "bin", ".cli-version"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: .cli-version will mark packaged installs as local too

prepare:cli-binary also runs for the package script, and .vscodeignore includes bin/**, so the marker written by local-bin.ts is shipped in the VSIX as well. That makes this branch true outside F5/dev sessions, so production installs can start injecting KILO_BWRAP_PATH from ~/.cache/kilo-vscode/bwrap whenever the bundled helper looks incomplete, which is broader than the local-only fallback this change is trying to add.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

@kilo-code-bot

kilo-code-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
packages/kilo-vscode/src/services/cli-backend/server-manager.ts 99 .cli-version also marks packaged installs as local, so the new cache-based KILO_BWRAP_PATH fallback can leak into production builds.

Fix these issues in Kilo Cloud

Files Reviewed (5 files)
  • packages/kilo-vscode/script/bwrap-helper.ts - 0 issues
  • packages/kilo-vscode/script/local-bin.ts - 0 issues
  • packages/kilo-vscode/src/services/cli-backend/cli-resources.ts - 0 issues
  • packages/kilo-vscode/src/services/cli-backend/server-manager.ts - 1 issue
  • packages/kilo-vscode/tests/unit/bwrap-helper.test.ts - 0 issues

Reviewed by gpt-5.4-20260305 · Input: 143.8K · Output: 13.8K · Cached: 617.8K

Review guidance: REVIEW.md from base branch main

@catrielmuller
catrielmuller merged commit cce4da3 into main Jun 24, 2026
23 checks passed
@catrielmuller
catrielmuller deleted the fix/vscode-local-bwrap-bundle branch June 24, 2026 18:04
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
…p-bundle

fix(vscode): bundle local bwrap helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants