test(cli): stabilize websocket idle timeout coverage - #11626
Merged
Conversation
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by gpt-5.4-20260305 · Input: 44.9K · Output: 4K · Cached: 216.3K Review guidance: REVIEW.md from base branch |
markijbema
enabled auto-merge
June 24, 2026 10:23
imanolmzd-svg
approved these changes
Jun 24, 2026
markijbema
disabled auto-merge
June 24, 2026 12:09
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
…le-test-flake test(cli): stabilize websocket idle timeout coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The linked failure is a test timing race: the same test passed on macOS and Windows and passed after the Linux job was rerun. Under load, the 20ms timeout can expire before the local socket's send callback runs, leaving a second timer that surfaces after HTTP fallback has already been selected.