fix(cli): restore read tool streaming - #11533
Merged
Merged
Conversation
chrarnoldus
approved these changes
Jun 22, 2026
imanolmzd-svg
approved these changes
Jun 22, 2026
NJ-2020
pushed a commit
to NJ-2020/kilocode
that referenced
this pull request
Jul 4, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
fix(cli): restore read tool streaming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenCode v1.14.51 integration in #11031 resolved conflicts in the Read tool by replacing the streaming path restored in #10077 with an
fs.readFilewhole-file decode. That made ordinary text reads buffer complete files before applying offsets, limits, or the 50 KB output cap, and left the streaming helper unused. In the same path, zero limits could produce non-advancing pagination, while UTF-16 truncation could split surrogate pairs and produce provider-rejected tool output (#10467).This restores UTF-8 reads through
AppFileSystem.streamand uses buffered encoding detection only as a fallback when bytes are not valid UTF-8. Stream teardown follows output caps, Effect interruption, and session cancellation. Explicit offsets and limits retain their current behavior, zero limits clamp to one item, and both line-level and compacted tool output preserve Unicode surrogate pairs.The contract remains explicit: an omitted offset still means line 1, and the tool does not maintain an implicit per-file cursor. Existing total-line reporting semantics are also unchanged, so line-limited reads can continue scanning to EOF even though file contents are no longer buffered in memory.
Fixes #10467