Skip to content

fix: silence interrupted session notifications - #11373

Merged
marius-kilocode merged 2 commits into
mainfrom
poised-exoplanet
Jun 17, 2026
Merged

fix: silence interrupted session notifications#11373
marius-kilocode merged 2 commits into
mainfrom
poised-exoplanet

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

Attention sounds currently treat every active-to-idle transition as a completed session. Manual interruption follows the same status transition, so pressing Escape or Stop can produce a misleading completion or error sound.

Use the canonical turn-close outcome in both the CLI and VS Code notification paths. Completion attention now fires only for completed turns, while interrupted turns and abort errors remain silent without changing genuine error, question, or permission notifications.

@kilo-code-bot

kilo-code-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (5 files)
  • .changeset/quiet-interrupted-sessions.md
  • packages/kilo-vscode/src/services/attention/service.ts
  • packages/kilo-vscode/tests/unit/attention.test.ts
  • packages/opencode/src/cli/cmd/tui/feature-plugins/system/notifications.ts
  • packages/opencode/test/cli/cmd/tui/notifications.test.ts

Reviewed by deepseek-v4-pro-20260423 · 501,226 tokens

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 52b3a01 into main Jun 17, 2026
24 checks passed
@marius-kilocode
marius-kilocode deleted the poised-exoplanet branch June 17, 2026 15:32
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
fix: silence interrupted session notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants