fix: silence interrupted session notifications - #11373
Merged
Merged
Conversation
marius-kilocode
enabled auto-merge
June 17, 2026 15:09
kirillk
approved these changes
Jun 17, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Reviewed by deepseek-v4-pro-20260423 · 501,226 tokens Review guidance: REVIEW.md from base branch |
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
fix: silence interrupted session notifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attention sounds currently treat every active-to-idle transition as a completed session. Manual interruption follows the same status transition, so pressing Escape or Stop can produce a misleading completion or error sound.
Use the canonical turn-close outcome in both the CLI and VS Code notification paths. Completion attention now fires only for completed turns, while interrupted turns and abort errors remain silent without changing genuine error, question, or permission notifications.