fix(agent-manager): clean up failed session moves - #11358
Merged
Conversation
Contributor
Code Review SummaryStatus: 1 Observation | Recommendation: Address before merge Overview
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (4 files)
Fix these issues in Kilo Cloud Reviewed by deepseek-v4-pro-20260423 · 379,801 tokens Review guidance: REVIEW.md from base branch |
kirillk
approved these changes
Jun 17, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
fix(agent-manager): clean up failed session moves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Move to Worktree cannot apply the source checkout's Git changes, worktree creation has already persisted the checkout and marked its setup as busy. The move reports an error to the originating chat but leaves the partial worktree registered. Without a terminal setup event, Agent Manager continues treating it as busy and hides the normal delete action.
Treat Git transfer as part of the worktree creation transaction. On transfer failure, use the existing worktree deletion path to remove persisted state, the checkout, and the generated branch. Then emit a terminal setup error so Agent Manager clears its busy state while preserving the original transfer error. Successful moves, Git patch behavior, base selection, and setup ordering remain unchanged.