fix(vscode): improve screen reader model navigation - #11352
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Reviewed by deepseek-v4-pro-20260423 · 257,026 tokens Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
June 17, 2026 12:53
johnnyeric
approved these changes
Jun 17, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
…tion fix(vscode): improve screen reader model navigation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #10688 established the initial combobox and listbox semantics for the VS Code model picker. Follow-up accessibility testing by a blind user found that two essential workflows were still blocked:
Nfor NVIDIA, updated the rendered results but did not move virtual screen-reader focus. The screen reader continued announcing the previously active option instead of a matching result.A grouped listbox cannot coherently represent provider headings that are both navigable parents and expandable controls. This change uses the ARIA editable-combobox-with-tree pattern instead. Provider headings are tree items with announced expanded or collapsed state, while models and the clear or default entry are child tree items. Navigation is derived from the currently visible tree, so
aria-activedescendantalways references a rendered node after filtering, collapsing, favorite changes, or provider updates.The keyboard behavior follows tree conventions: Up and Down traverse visible items, Left moves to a parent or collapses it, Right expands a provider or enters its first model, Home and End move to the visible edges, Enter toggles a provider or commits a model, and Escape cancels without changing the selection. Filtering moves virtual focus to a visible matching model. Native text editing remains intact until tree navigation begins, so Left, Right, Home, End, Backspace, and Delete continue to work normally in the editable search field.
Favorites, duplicate favorite rows, clear or default selection, expanded preview behavior, pointer selection, and
/modelfocus restoration remain predictable under the same interaction model. No Agent Manager-specific UI components are changed.Follow-up to #10688.