Skip to content

fix(cli): restore permission override tests - #11315

Merged
kirillk merged 1 commit into
mainfrom
puzzled-abacus
Jun 16, 2026
Merged

fix(cli): restore permission override tests#11315
kirillk merged 1 commit into
mainfrom
puzzled-abacus

Conversation

@kirillk

@kirillk kirillk commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace the accidental WithInstance.provide calls in the permission override tests with the existing provideTestInstance fixture.
  • Restores the failing CLI typecheck and Windows unit test on main.

Validation

  • bun test ./test/kilocode/agent-permission-overrides.test.ts
  • bun run typecheck

@kilo-code-bot

kilo-code-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • packages/opencode/test/kilocode/agent-permission-overrides.test.ts

Reviewed by deepseek-v4-pro-20260423 · 227,967 tokens

Review guidance: REVIEW.md from base branch main

@kirillk
kirillk enabled auto-merge June 16, 2026 16:41
@kirillk
kirillk merged commit 2caccfc into main Jun 16, 2026
20 checks passed
@kirillk
kirillk deleted the puzzled-abacus branch June 16, 2026 16:54
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
fix(cli): restore permission override tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants