Skip to content

feat(vscode): remove dead layout setting from Display settings - #11312

Merged
imanolmzd-svg merged 1 commit into
mainfrom
remove-dead-layout-setting
Jun 16, 2026
Merged

feat(vscode): remove dead layout setting from Display settings#11312
imanolmzd-svg merged 1 commit into
mainfrom
remove-dead-layout-setting

Conversation

@kilo-code-bot

@kilo-code-bot kilo-code-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

What

Removes the Layout (auto | stretch) toggle from the Display settings tab — it was never functional.

Why

The backend schema marks the field @deprecated with the note "Always uses stretch layout". The engine ignores the user's choice entirely, so the setting gives users a false impression of control while having zero effect.

Changes

  • DisplayTab.tsx — remove LAYOUT_OPTIONS array and the Layout <SettingsRow> / <Select> block
  • types/messages/config.ts — remove layout?: "auto" | "stretch" from the Config interface
  • settings-io.ts — remove "layout" from the KNOWN_KEYS allowlist (import/export)
  • 20 i18n files — remove 4 translation keys per language (settings.display.layout.{title,description,auto,stretch}), 80 keys total

The LayoutOption interface in DisplayTab.tsx is retained because it is still used by TERMINAL_OPTIONS and CODE_EDIT_OPTIONS.

The deprecated layout field in the shared upstream opencode schema (packages/opencode/src/config/config.ts) is intentionally left untouched to minimise fork-merge conflicts.


Built for Imanol Maiztegui by Kilo for Slack

The layout (auto | stretch toggle) in the Display settings tab was dead
code: the backend schema marks it @deprecated with the note 'Always uses
stretch layout', and the engine ignores the user choice entirely.

Remove the setting from:
- DisplayTab.tsx (UI row + LAYOUT_OPTIONS array)
- Config type (layout field)
- settings-io.ts KNOWN_KEYS allowlist
- All 20 language i18n files (80 translation keys total)
@kilo-code-bot

kilo-code-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (23 files)
  • packages/kilo-vscode/webview-ui/src/components/settings/DisplayTab.tsx
  • packages/kilo-vscode/webview-ui/src/components/settings/settings-io.ts
  • packages/kilo-vscode/webview-ui/src/types/messages/config.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ar.ts
  • packages/kilo-vscode/webview-ui/src/i18n/br.ts
  • packages/kilo-vscode/webview-ui/src/i18n/bs.ts
  • packages/kilo-vscode/webview-ui/src/i18n/da.ts
  • packages/kilo-vscode/webview-ui/src/i18n/de.ts
  • packages/kilo-vscode/webview-ui/src/i18n/en.ts
  • packages/kilo-vscode/webview-ui/src/i18n/es.ts
  • packages/kilo-vscode/webview-ui/src/i18n/fr.ts
  • packages/kilo-vscode/webview-ui/src/i18n/it.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ja.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ko.ts
  • packages/kilo-vscode/webview-ui/src/i18n/nl.ts
  • packages/kilo-vscode/webview-ui/src/i18n/no.ts
  • packages/kilo-vscode/webview-ui/src/i18n/pl.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ru.ts
  • packages/kilo-vscode/webview-ui/src/i18n/th.ts
  • packages/kilo-vscode/webview-ui/src/i18n/tr.ts
  • packages/kilo-vscode/webview-ui/src/i18n/uk.ts
  • packages/kilo-vscode/webview-ui/src/i18n/zh.ts
  • packages/kilo-vscode/webview-ui/src/i18n/zht.ts

Reviewed by deepseek-v4-pro-20260423 · 716,441 tokens

Review guidance: REVIEW.md from base branch main

@imanolmzd-svg
imanolmzd-svg enabled auto-merge (squash) June 16, 2026 14:15
@imanolmzd-svg
imanolmzd-svg merged commit 290d5f4 into main Jun 16, 2026
20 checks passed
@imanolmzd-svg
imanolmzd-svg deleted the remove-dead-layout-setting branch June 16, 2026 14:27
NJ-2020 pushed a commit to NJ-2020/kilocode that referenced this pull request Jul 4, 2026
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
…Org#11312)

The layout (auto | stretch toggle) in the Display settings tab was dead
code: the backend schema marks it @deprecated with the note 'Always uses
stretch layout', and the engine ignores the user choice entirely.

Remove the setting from:
- DisplayTab.tsx (UI row + LAYOUT_OPTIONS array)
- Config type (layout field)
- settings-io.ts KNOWN_KEYS allowlist
- All 20 language i18n files (80 translation keys total)

Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants