refactor(kilo-console): use Kilo UI boundary - #11288
Merged
Merged
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge All issues from the previous review have been addressed:
Files Reviewed (87 files)
Previous Review Summaries (3 snapshots, latest commit 6291375)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 6291375)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Resolved from previous review
Files Reviewed (45 files)
Fix these issues in Kilo Cloud Previous review (commit 6866133)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (1 file)
Fix these issues in Kilo Cloud Previous review (commit f216118)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (1 file)
Reviewed by deepseek-v4-pro-20260423 · 745,379 tokens Review guidance: REVIEW.md from base branch |
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
catrielmuller
force-pushed
the
mark/kilo-console-ui-boundary
branch
from
June 16, 2026 14:09
6866133 to
6291375
Compare
catrielmuller
approved these changes
Jun 16, 2026
| local.onRendered?.() | ||
| }) | ||
|
|
||
| createEffect(() => { |
Contributor
Author
There was a problem hiding this comment.
WARNING: Redundant annotation re-rendering — the first createEffect (line 71) already recreates the FileDiff instance whenever local.annotations changes because it reads local.annotations reactively on line 72. This second effect calls setLineAnnotations + rerender() on the new instance, applying the same annotations twice. Annotation-only changes (e.g. a comment on a diff line) shouldn't require full instance teardown and recreation.
Consider removing the second effect and instead merging its logic into the first effect so that annotation-only changes call setLineAnnotations/rerender() without recreating the instance.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| <div data-slot="session-review-large-diff"> | ||
| <div data-slot="session-review-large-diff-title" data-state="loading"> | ||
| <Spinner /> | ||
| <span>Loading diff...</span> |
Contributor
Author
There was a problem hiding this comment.
SUGGESTION: Hardcoded English string "Loading diff..." — the rest of this component uses i18n.t(...) for user-visible text. This should be localized via the i18n context for consistency.
Suggested change
| <span>Loading diff...</span> | |
| <span>{i18n.t("ui.sessionReview.loading")}</span> |
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
…boundary refactor(kilo-console): use Kilo UI boundary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Route the project console's file and session review components through
@kilocode/kilo-web-uiinstead of importing the upstream OpenCode UI package directly.This preserves the existing implementation while keeping Kilo product code behind the Kilo-owned UI boundary. It also allows the direct
@opencode-ai/uidependency to be removed fromkilo-consoleseparately.