fix(vscode): allow removing provider reasoning - #11238
Merged
Merged
Conversation
marius-kilocode
enabled auto-merge (squash)
June 15, 2026 09:13
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The only change since the previous review at Files Reviewed (6 files)
Previous Review Summary (commit d3ce281)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit d3ce281)Status: No Issues Found | Recommendation: Merge The fix is correct and well-scoped. The deep-merge/ Key observations:
Files Reviewed (5 files)
Reviewed by claude-4.6-sonnet-20260217 · 131,810 tokens Review guidance: REVIEW.md from base branch |
chrarnoldus
approved these changes
Jun 15, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
* fix(vscode): allow removing provider reasoning * style(vscode): format provider regression test --------- Co-authored-by: Christiaan Arnoldus <christiaan.arnoldus@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit Provider omits a model's reasoning field when it is disabled, but provider updates are deep-merged with the existing global config. The previously saved
reasoning: truetherefore survived and reappeared when the provider was reloaded.Emit the same explicit null deletion sentinel already used for removed models and variants when reasoning is cleared, and accept that sentinel through the config update schema. Existing provider fields remain intact, including sibling models and model variants, while the persisted reasoning override is removed.
Regression coverage exercises the extension save path and the real global config add, persist, remove, and reload lifecycle.
Fixes #11193