fix(cli): validate external download inputs - #11179
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Other Observations (not in diff)
Files Reviewed (7 files)
Overall assessment: The PR correctly addresses the three reported code-scanning alerts. The Fix these issues in Kilo Cloud Reviewed by claude-4.6-sonnet-20260217 · 1,730,931 tokens Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge (squash)
June 12, 2026 17:50
johnnyeric
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Action comments currently allow attachment-like URLs to flow directly into authenticated requests, while language server release metadata influences archive and executable paths. This exposes request-forgery and command-injection trust boundaries reported by code scanning.
Canonicalize GitHub attachment URLs to the two supported route shapes before fetching them. Language server downloads now use fixed local archive names, clangd release tags are allowlisted before becoming executable paths, and Windows ZIP extraction passes paths through environment variables instead of embedding them in PowerShell source.
The attachment policy and regression coverage live in Kilo-owned paths. Shared OpenCode files retain only narrow, annotated validation hooks to limit future upstream merge conflicts.
Addresses: