feat(vscode): render submitted review comments across chat surfaces - #11173
Conversation
marius-kilocode
changed the title
11da2ad to
c3b1eba
Compare
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| if (data.comments.length === 0 || data.comments.length > LIMIT) return undefined | ||
|
|
||
| const comments: ReviewCommentData[] = [] | ||
| for (const value of data.comments) { |
There was a problem hiding this comment.
SUGGESTION: Variable value in the for loop shadows the outer value parameter of the view function.
The outer value is no longer needed past line 80, so this isn't a functional bug, but it's a style guideline violation (no-shadow) and could confuse readers. Consider using a different name like entry or raw.
| for (const value of data.comments) { | |
| for (const entry of data.comments) { |
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| mime: file.mime, | ||
| dataUrl: file.url, | ||
| })) | ||
| if (images.length === 0) return |
There was a problem hiding this comment.
WARNING: Early return when images.length === 0 is fine for skipping image restore, but it means if a failed message has review comments AND empty user text (review-only send), control reaches this point with review comments already restored but the textarea never gets focused (the textareaRef.focus() call on line 354 is only reached when draft is truthy). The user would need to manually click into the input.
Consider adding a focus call after the image block, or at least after replaceReviewComments:
if (failed.review) {
replaceReviewComments(failed.review.comments)
textareaRef?.focus()
}Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Other Observations (not in diff)No additional issues found in unchanged code. Files Reviewed (11 files)
Fix these issues in Kilo Cloud Reviewed by claude-4.6-sonnet-20260217 · 1,340,672 tokens Review guidance: REVIEW.md from base branch |
…ilo-Org#11173) * feat(vscode): render submitted review comments interactively * chore: update kilo-vscode visual regression baselines --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 participants
Submitted review comments are currently serialized into the model prompt as Markdown, which makes subsequent session messages show implementation-oriented prompt text instead of the interactive review UI users started from.
This applies across the Kilo VS Code extension's shared chat experience, including both the sidebar chat and Agent Manager sessions. It preserves a validated, size-bounded review-comment payload alongside the existing model-visible Markdown and reuses the prompt's review cards when rendering user messages. The cards remain clickable for comment details and file navigation after optimistic submission, session reload, and cloud-session continuation, while failed sends restore both the editable prompt and its review comments.
Review-bearing input uses the normal message path rather than expanding slash commands, keeping the backend command API unchanged while making persisted review feedback consistent across extension chat surfaces.