feat(vscode): use terminal.integrated font settings in Agent Manager xterm - #11144
Merged
Conversation
…xterm terminals Reads terminal.integrated.fontFamily and terminal.integrated.fontSize (with editor font fallback) instead of the editor font CSS var. A config watcher broadcasts fontChanged messages so live terminals update without a reload. Nerd Font glyphs now render correctly in Agent Manager terminal tabs.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge What Changed (incremental — commit
|
RSO
approved these changes
Jun 12, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
…ted-font feat(vscode): use terminal.integrated font settings in Agent Manager xterm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terminal.integrated.fontFamilyandterminal.integrated.fontSize(with fallback toeditor.fontFamily/editor.fontSize) instead of the--vscode-editor-font-familyCSS variable and Kilo's--font-size-base.terminal.integrated.fontFamilynow render correctly in terminal tabs — no more missing-glyph boxes.vscode.workspace.onDidChangeConfigurationwatcher broadcastsagentManager.terminal.fontChangedto the webview when font settings change at runtime, so live terminals pick up the new font without requiring a reload.fontSizeChanged/readymessages (which control the Kilo chat UI font size) no longer propagate toterm.options.fontSize— the terminal font is now fully independent of the chat UI font.Implementation
terminal-font.ts(new): readsterminal.integrated.*andeditor.font*config, exposesreadTerminalFont(),affectsTerminalFont(), andwatchTerminalFont(). Added to the arch-testVSCODE_ALLOWEDlist.types.ts: addsfont: TerminalFonttoTerminalCreatedMessageand a newTerminalFontChangedMessageoutbound type.terminal-routing.ts: addsgetTerminalFont()toTerminalRoutingDeps; includesfontin everyterminal.createdpost.AgentManagerProvider.ts: suppliesgetTerminalFontdep, sets up a font-change watcher that poststerminal.fontChangedto the webview.state.ts: addsTerminalFontinterface andfontfield toTerminalTabState/TerminalCreatedEvent.render.tsx: forwardsfont={term.font}prop to<TerminalTab>.TerminalTab.tsx: usesprops.fontfor initial xterm options; handlesagentManager.terminal.fontChangedin the message subscription for live updates.