docs(customize): clarify agent permission rules - #11141
Conversation
|
@singhvishalkr is attempting to deploy a commit to the Kilo Code Team on Vercel. A member of the Team first needs to authorize it. |
lambertjosh
left a comment
lambertjosh
left a comment
There was a problem hiding this comment.
Thanks for this, just a few minor comments.
| | `ask` | Prompt before running the matching tool call. | | ||
| | `deny` | Block the matching tool call. | | ||
|
|
||
| Rules can be written as a scalar action for the whole permission or as a pattern map: |
There was a problem hiding this comment.
Can we rephrase this using plainer language?
lambertjosh
left a comment
lambertjosh
left a comment
There was a problem hiding this comment.
Sorry meant to request changes.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Previously Flagged (carried forward from prior review)
Resolved in this update
Files Reviewed (1 file changed, 6 total)
Fix these issues in Kilo Cloud Previous Review Summaries (4 snapshots, latest commit 6e99eb0)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 6e99eb0)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Previously Flagged (carried forward from prior review)
Resolved in this update
Files Reviewed (6 files)
Fix these issues in Kilo Cloud Previous review (commit d3172f3)Status: No Issues Found | Recommendation: Merge Previously Flagged (unchanged from prior review)
Files Reviewed (5 files)
Incremental Review (3a55bce → d3172f3)The incremental commit Previous review (commit 3a55bce)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Previously Flagged (unchanged from prior review)
Files Reviewed (2 files changed in this increment)
Previous review (commit 17fe1d6)Status: No Issues Found | Recommendation: Merge NotesThe page is well-structured with clear sections covering actions, precedence, patterns, file paths, shell commands, sensitive files, subagent delegation, and troubleshooting. Cross-links from Custom Subagents, the Customize index, and Auto-Approving Actions are correctly formatted. Existing reviewer comments (intro clarity, adding Rule Precedence to auto-approving-actions) are reasonable suggestions but not blockers — the intro has already been revised and auto-approving-actions received a new Markdown Agent Files section. All internal links ( This is a docs-only change — no changeset required. Files Reviewed (5 files)
Reviewed by deepseek-v4-pro-20260423 · 158,662 tokens Review guidance: REVIEW.md from base branch |
|
Current head now clarifies that the agent-permissions page is the YAML/frontmatter form, keeps the kilo.jsonc mapping explicit, and adds the same example under auto-approving actions. That should cover both review comments on the docs wording and placement. |
|
Updated in
Verification:
I could not run the docs package test/build locally because Bun is not available on this Windows environment. |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
d3172f3 to
6e99eb0
Compare
|
Rebased this on current main and updated the moved Composio toolkit catalog link that was failing link-checker. The docs build, markdown table check, forbidden-string check, link-checker, and typecheck jobs are passing on the latest head. Vercel still reports authorization required for the preview deployment. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lambertjosh
left a comment
lambertjosh
left a comment
There was a problem hiding this comment.
Looks great, thanks for the changes! I fixed a minor conflict and we should be good.
…ssion-rules docs(customize): clarify agent permission rules
2 participants
Fixes #11106.
What changed:
Verification: