Skip to content

fix(vscode): keep HTTP status with error title - #11100

Merged
marius-kilocode merged 3 commits into
mainfrom
neighborly-visitor
Jun 11, 2026
Merged

fix(vscode): keep HTTP status with error title#11100
marius-kilocode merged 3 commits into
mainfrom
neighborly-visitor

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Tool errors currently treat the HTTP status and status text as one flexible message. In constrained sidebar layouts, that can place the status code away from the error title or split the status text mid-word, making errors such as GitHub API error: 401 Unauthorized difficult to scan.

This keeps a leading three-digit HTTP status grouped with the structured error title while allowing the descriptive status text to wrap independently. General tool errors retain their existing title/detail treatment, and very narrow layouts prioritize readable text over the decorative error icon.

The composite webview stories now cover both an HTTP error and a filesystem error at standard and narrow sidebar widths so future layout changes preserve the intended grouping and wrapping behavior.

Before:
image

After:
image

@kilo-code-bot

kilo-code-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The implementation is correct across all three commits. The HTTP status regex (/^(\d{3})(?:\s+|$)/) cleanly extracts the three-digit code from message, and message.slice(code.length).trimStart() handles the trailing space correctly. The message-part-tool-error-heading wrapper with flex: none; white-space: nowrap achieves the intended grouping.

The follow-up fix(ui): align tool error text baselines commit correctly hoists shared font properties (font-family, font-size, font-style, line-height, letter-spacing) to the parent message-part-tool-error-content container and adds align-items: baseline to both the content container and the heading wrapper — a clean refactor with no duplication or regressions.

Files Reviewed (6 files)
  • .changeset/keep-error-status-inline.md
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/composite-webview/tool-errors-200-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/composite-webview/tool-errors-chromium-linux.png
  • packages/kilo-ui/src/components/message-part.css
  • packages/kilo-ui/src/components/message-part.tsx
  • packages/kilo-vscode/webview-ui/src/stories/composite.stories.tsx

Reviewed by claude-4.6-sonnet-20260217 · 347,939 tokens

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit c922ca7 into main Jun 11, 2026
23 checks passed
@marius-kilocode
marius-kilocode deleted the neighborly-visitor branch June 11, 2026 09:23
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
fix(vscode): keep HTTP status with error title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants