Skip to content

fix(vscode): improve custom question answers - #11051

Merged
lambertjosh merged 7 commits into
mainfrom
fix/question-custom-answer-selection
Jun 11, 2026
Merged

fix(vscode): improve custom question answers#11051
lambertjosh merged 7 commits into
mainfrom
fix/question-custom-answer-selection

Conversation

@lambertjosh

@lambertjosh lambertjosh commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Single option question tool previously never actually showed the custom entry as selected, which was quite annoying and misleading. Additionally it would show two submit buttons which was unnecessary, since clicking the first one actually submitted the question. UX was poor.

Before

image

After

image

Details

  • select the custom-answer radio when its row or textbox receives interaction
  • switch cleanly back to predefined answers without submitting retained custom text
  • show a single submit action while entering a custom answer

Custom text entry previously left the radio selection visually out of sync and exposed two submit buttons. This keeps the selection and controls consistent without changing question reply lifecycle handling.

@kilo-code-bot

kilo-code-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (10 files)
  • .changeset/select-custom-question-answer.md — updated changeset description (user-facing)
  • packages/kilo-vscode/webview-ui/src/components/chat/QuestionDock.tsx — adds selectCustom(), close(), customPicked derivation from store.editing, and hides footer actions while editing
  • packages/kilo-vscode/tests/unit/question-dock-contract.test.ts — updated assertion: footer actions hidden during editing
  • packages/kilo-vscode/tests/question-dock-selection.spec.ts — added then removed (Playwright browser spec)
  • packages/kilo-vscode/webview-ui/src/stories/chat.stories.tsx — enriched then reverted QuestionDockSingle story render
  • All files from previous review (unchanged) — carried forward as clean

Reviewed by claude-4.6-sonnet-20260217 · 562,351 tokens

Review guidance: REVIEW.md from base branch main

@lambertjosh
lambertjosh force-pushed the fix/question-custom-answer-selection branch from 4248062 to 69f193d Compare June 10, 2026 12:48
@lambertjosh
lambertjosh force-pushed the fix/question-custom-answer-selection branch from a975497 to c175883 Compare June 10, 2026 17:54
@lambertjosh lambertjosh changed the title fix(vscode): sync custom question selection fix(vscode): improve custom question answers Jun 10, 2026
@lambertjosh

Copy link
Copy Markdown
Contributor Author

Validated the fixes for single-select questions. Left multi-select unchanged for now.

working_question.mov

@lambertjosh
lambertjosh merged commit 3f9b5be into main Jun 11, 2026
20 checks passed
@lambertjosh
lambertjosh deleted the fix/question-custom-answer-selection branch June 11, 2026 01:12
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
…nswer-selection

fix(vscode): improve custom question answers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants