test(cli): remove network-dependent session export case - #11012
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Incremental review against the previous pass at The PR cleanly removes a network-dependent E2E test case that was flaky by design: the worker persistence assertion was coupled to a transport failure ( Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (1 file)
Reviewed by claude-4.6-sonnet-20260217 · 246,693 tokens Review guidance: REVIEW.md from base branch |
bd179a2 to
fd4b7a2
Compare
…port-worker-e2e test(cli): remove network-dependent session export case
The base branch now explicitly opts this test into its custom loopback endpoint, so it no longer falls back to the production session-export service. That fixes the production traffic risk, but the worker case still tests persistence by relying on an upload failure.
Worker shutdown deliberately flushes pending events. Successful uploads and terminal responses remove their rows from SQLite. The test checks for those rows after shutdown, so it passes only because
127.0.0.1:1refuses the upload and leaves the rows queued. Its persistence assertion is therefore coupled to a specific transport failure rather than to the storage behavior it intends to verify.Remove only this worker case and its private fixtures. Focused tests already cover storage ordering, persisted metadata, secret scrubbing, upload outcomes, and shutdown behavior. The two workspace capture integration cases remain. This preserves the useful integration coverage without retaining a worker test that conflates persistence with failed delivery.