Skip to content

Skip pausing auto-scroll on question answer - #10946

Merged
imanolmzd-svg merged 1 commit into
mainfrom
imanol/scroll-question-control
Jun 5, 2026
Merged

Skip pausing auto-scroll on question answer#10946
imanolmzd-svg merged 1 commit into
mainfrom
imanol/scroll-question-control

Conversation

@imanolmzd-svg

@imanolmzd-svg imanolmzd-svg commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Part of #10741
Closes #10741

Why

Answering a question (Clicking on the chat) was interpreted as an event that stopped scrolling (See before video)

Implementation

Extract helper utilities to identify interactive elements (buttons, inputs, textareas, contenteditable) and nested scrollable containers. Skip pausing auto-scroll when the user interacts with form controls or question answer elements, preventing false positives that would stop the chat from following new content.

Screenshots / Video

Before

before-question-fix.mov

After

after-question-fix.mov

Testing

  • Unit tests pass
  • Manual verification as shown above

…oll intent

Extract helper utilities to identify interactive elements (buttons,
inputs, textareas, contenteditable) and nested scrollable containers.
Skip pausing auto-scroll when the user interacts with form controls
or question answer elements, preventing false positives that would
stop the chat from following new content.
@imanolmzd-svg
imanolmzd-svg enabled auto-merge (squash) June 5, 2026 11:49
@kilo-code-bot

kilo-code-bot Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The refactoring is clean. isControl and isNested are well-extracted helpers with correct logic. The markUser change correctly guards against false positives from clicks on interactive controls (buttons, inputs, textareas, etc.) and contenteditable regions without affecting the WheelEvent nested-scroll guard. No resource leaks, race conditions, or logic errors detected.

Files Reviewed (3 files)
  • .changeset/ignore-control-scroll-intent.md
  • packages/kilo-ui/src/hooks/auto-scroll.ts (new file)
  • packages/kilo-ui/src/hooks/create-auto-scroll.tsx

Reviewed by claude-4.6-sonnet-20260217 · 429,150 tokens

Review guidance: REVIEW.md from base branch main

@imanolmzd-svg
imanolmzd-svg merged commit 6a64794 into main Jun 5, 2026
22 of 24 checks passed
@imanolmzd-svg
imanolmzd-svg deleted the imanol/scroll-question-control branch June 5, 2026 12:22
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
…oll intent (Kilo-Org#10946)

Extract helper utilities to identify interactive elements (buttons,
inputs, textareas, contenteditable) and nested scrollable containers.
Skip pausing auto-scroll when the user interacts with form controls
or question answer elements, preventing false positives that would
stop the chat from following new content.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-scroll lost on permission prompts and edit calls

2 participants