Skip to content

fix: remove accidental /review command re-introduction (OpenCode v1.3.0 merge) - #10664

Closed
kilo-code-bot[bot] wants to merge 1 commit into
mainfrom
session/agent_2f4b7fe9-32c2-4398-867b-8c09d67d6da1
Closed

fix: remove accidental /review command re-introduction (OpenCode v1.3.0 merge)#10664
kilo-code-bot[bot] wants to merge 1 commit into
mainfrom
session/agent_2f4b7fe9-32c2-4398-867b-8c09d67d6da1

Conversation

@kilo-code-bot

@kilo-code-bot kilo-code-bot Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

What

Re-disables the /review slash command that was accidentally re-introduced during the OpenCode v1.3.0 upstream merge.

History

  • /review was intentionally disabled when code reviews were first built — it was replaced by /local-review and /local-review-uncommitted, which offer better UX and clearer scope.
  • During the OpenCode v1.3.0 merge (PR OpenCode v1.3.0 #8772, commit b181114, Apr 11 2026), the kilocode_change comment block suppressing /review was dropped in conflict resolution. The command was silently re-activated.
  • This shipped in Kilo v7.2.5 (Apr 13, 2026).

Changes

  • packages/opencode/src/command/index.ts: Removes the commands[Default.REVIEW] registration block. Replaces it with a kilocode_change comment block explaining why /review is disabled and referencing the accidental re-introduction. Also removes the now-unused PROMPT_REVIEW import (annotated with a kilocode_change comment).
  • packages/opencode/test/kilocode/local-review-command.test.ts: Adds a regression test that instantiates the real Command service and asserts "review" is not in the registered command list. The test includes a comment referencing PR OpenCode v1.3.0 #8772 so future readers understand why the assertion exists.

Why a test

The previous suppression was comment-only and invisible to automated checks — it was silently discarded during merge conflict resolution. The new test will fail CI if /review is re-registered, making any future re-introduction deliberate rather than accidental.


Built for Imanol Maiztegui by Kilo for Slack

…Code v1.3.0 merge

/review was intentionally disabled in favour of /local-review and
/local-review-uncommitted. It was accidentally re-activated during the
OpenCode v1.3.0 upstream merge (PR #8772, commit b181114) when the
kilocode_change suppression comment was lost in conflict resolution,
and shipped in Kilo v7.2.5.

This commit re-disables /review with a clear kilocode_change marker
and adds a unit test guard to prevent it from being silently
re-introduced in future upstream merges.
@kilo-code-bot

kilo-code-bot Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The change is correct and well-structured:

  • packages/opencode/src/command/index.ts: /review registration is cleanly removed. The kilocode_change comment block is placed correctly and includes clear reasoning + a "Do NOT re-enable" guard note.
  • packages/opencode/test/kilocode/local-review-command.test.ts: The regression test is idiomatic (uses the real Command service via testEffect + it.instance, avoids mocks), references the original PR/commit for traceability, and will actually fail CI if /review is ever re-registered.
  • Default.REVIEW is kept in the Default object as a dead constant — intentional for upstream merge hygiene so the key stays in sync with opencode.
  • packages/opencode/src/command/template/review.txt is left behind (no import, no delete) — correct, minimizes diff against upstream.
  • No changeset added. Acceptable here: this re-disables a command that was accidentally re-activated, restoring the prior intentional state rather than introducing new user-visible behavior.

Fix these issues in Kilo Cloud

Files Reviewed (2 files)
  • packages/opencode/src/command/index.ts
  • packages/opencode/test/kilocode/local-review-command.test.ts

Reviewed by claude-4.6-sonnet-20260217 · 642,526 tokens

Review guidance: REVIEW.md from base branch main

@github-actions

Copy link
Copy Markdown
Contributor

To stay organized pull requests are automatically closed after 30 days of inactivity. If the pull request is still relevant please reopen it or create a fresh new one.

@github-actions github-actions Bot closed this Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants