fix: remove accidental /review command re-introduction (OpenCode v1.3.0 merge) - #10664
Closed
kilo-code-bot[bot] wants to merge 1 commit into
Closed
fix: remove accidental /review command re-introduction (OpenCode v1.3.0 merge)#10664kilo-code-bot[bot] wants to merge 1 commit into
kilo-code-bot[bot] wants to merge 1 commit into
Conversation
…Code v1.3.0 merge /review was intentionally disabled in favour of /local-review and /local-review-uncommitted. It was accidentally re-activated during the OpenCode v1.3.0 upstream merge (PR #8772, commit b181114) when the kilocode_change suppression comment was lost in conflict resolution, and shipped in Kilo v7.2.5. This commit re-disables /review with a clear kilocode_change marker and adds a unit test guard to prevent it from being silently re-introduced in future upstream merges.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The change is correct and well-structured:
Fix these issues in Kilo Cloud Files Reviewed (2 files)
Reviewed by claude-4.6-sonnet-20260217 · 642,526 tokens Review guidance: REVIEW.md from base branch |
Contributor
|
To stay organized pull requests are automatically closed after 30 days of inactivity. If the pull request is still relevant please reopen it or create a fresh new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-disables the
/reviewslash command that was accidentally re-introduced during the OpenCode v1.3.0 upstream merge.History
/reviewwas intentionally disabled when code reviews were first built — it was replaced by/local-reviewand/local-review-uncommitted, which offer better UX and clearer scope.kilocode_changecomment block suppressing/reviewwas dropped in conflict resolution. The command was silently re-activated.Changes
packages/opencode/src/command/index.ts: Removes thecommands[Default.REVIEW]registration block. Replaces it with akilocode_changecomment block explaining why/reviewis disabled and referencing the accidental re-introduction. Also removes the now-unusedPROMPT_REVIEWimport (annotated with akilocode_changecomment).packages/opencode/test/kilocode/local-review-command.test.ts: Adds a regression test that instantiates the realCommandservice and asserts"review"is not in the registered command list. The test includes a comment referencing PR OpenCode v1.3.0 #8772 so future readers understand why the assertion exists.Why a test
The previous suppression was comment-only and invisible to automated checks — it was silently discarded during merge conflict resolution. The new test will fail CI if
/reviewis re-registered, making any future re-introduction deliberate rather than accidental.Built for Imanol Maiztegui by Kilo for Slack