feat(vscode): implement notification sound playback and preview - #10545
feat(vscode): implement notification sound playback and preview#10545IamCoder18 wants to merge 2 commits into
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge All Previously Flagged Issues Resolved
Other Observations (not blocking)
Files Reviewed (13 files)
Reviewed by claude-sonnet-4.6 · 1,376,103 tokens Review guidance: REVIEW.md from base branch |
1fbf8bd to
4974717
Compare
aae35a0 to
5eae7f5
Compare
857f8cb to
7a79532
Compare
|
Another video, showing no audio plays when VS Code is focused. 2026-05-25.21-24-57.mp4 |
|
All CI pass, code review found no issues, and I've manually read over the changes. |
7a79532 to
af6330f
Compare
|
I added a new "Play Sounds When Focused" setting (default 2026-05-27.18-56-31.mp4 |
5122e30 to
c463a6a
Compare
Introduce sound playback for core notification events (agent completion, permission requests, questions, and errors) with a UI preview feature. - Add 45+ localized .wav alert assets to the extension package - Implement sound configuration UI tab with multi-language i18n support - Add .vscodeignore paths to ensure audio assets bundle correctly - Include changeset configuration for minor version release
…ounds Add a new VS Code-only setting that allows sound notifications to play even when the VS Code window is focused. The setting is off by default, preserving existing behavior. Includes UI toggle in Notifications settings tab and localization strings for all supported languages.
c463a6a to
0893b86
Compare
|
This feature was actually done upstream and is now on main with: #11031. Unfortunately this will make the current PR architecture obsolete. There are still many good parts we can reuse. Let's see what works here. |
|
Closing this PR based on the context from #8278. Please let me know if I this is incorrect and I I'll reopen. |
Context
This is the first split-up and refined PR from #8278 based on feedback from @marius-kilocode
This PR adds audio notification playback to the Kilo Code VS Code extension, addressing user needs for auditory feedback when agent tasks complete, permissions are required, or errors occur. Previously, the notification settings (
kilo-code.new.sounds.*) existed but were not wired to any actual sound playback.Closes #7877
Closes #8127
Closes #10321
Implementation
Sound Utility (
src/util/sound.ts): Cross-platform sound playback supporting:SoundNotificationService (
src/util/sound-notification.ts): Centralized service that:shouldNotify()Settings Integration: UI in Notifications tab with:
Screenshots
Walkthrough with Question, Permission, and Agent Completion as well as Test sound button (Please unmute the video)
2026-05-23.09-54-22.mp4
Multiple sounds in quick succession (700ms cooldown)
2026-05-23.10-26-57.mp4
Error sound plays
2026-05-23.10-33-09.mp4
Testing sound + sounds in quick succession on Windows
2026-05-23.10-48-23.mp4
How to Test
I've tested the thoroughly on Ubuntu 22.04 and partially on Windows 11, but not on macOS.