fix(vscode): keep custom provider picker open after partial add

[truffle-dev]

Context

Refs #10139 (first of two reports in that issue).

The "Fetched models" picker in the Custom Provider dialog wipes itself after the user clicks Add Selected, even when only a subset of the fetched models was added. The user has to re-enter the base URL/key to trigger another fetch in order to add the rest. The expected behavior is for the un-picked models to stay visible.

Implementation

addSelected() in CustomProviderDialog.tsx unconditionally called setFetchedModels(undefined) after merging the picked rows into form.models. That cleared the picker entirely.

The fix filters the picked IDs out of fetchedModels and clears the selection. Only when every fetched model has been added do we close the picker (the previous behavior). Search input is preserved across partial adds so the user can keep narrowing.

The auto-fetch effect at line 167 is unaffected: it watches fetchURL/fetchKey signals, not the picker state, so partial-add no longer races against a refetch.

The second report in #10139 (API key not persisting after Submit) is intentionally out of scope here; I left a comment on the issue with what I traced and what reproduction info would help nail it down.

Screenshots

N/A — picker visibility change; no visual layout shift.

How to Test

1. Open the Custom Provider dialog and enter a base URL with several fetchable models (e.g. an OpenRouter-compatible endpoint).
2. Wait for the picker to populate; deselect a couple of models.
3. Click Add Selected.
4. Before this fix: the picker disappears and you have to clear/re-enter the URL or key to fetch again.
5. After this fix: the un-picked models stay visible, the selection clears, and you can pick more without re-fetching. Adding the last remaining model still closes the picker.

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Overview

The change in addSelected() is correct and well-scoped. After a partial add:

• pickedIds is built from picked (already filtered to selected IDs present in fetchedModels)
• remaining correctly spans the full models snapshot, not just visible/filtered rows
• When remaining models exist: picker updates to show only the un-added models, selection is cleared
• When all models are added: original close behavior (clear picker + search) is preserved
• Search is intentionally preserved across partial adds, matching the PR description
• No memory leaks introduced — the intermediate Sets are short-lived locals
• The auto-fetch createEffect at line 167 watches fetchURL/fetchKey signals only, so it is unaffected by the setFetchedModels call in this path

One minor observation (not worth blocking): pickedIds could be replaced by sel directly (const remaining = models.filter((m) => !sel.has(m.id))), since picked is already models.filter((m) => sel.has(m.id)). Using pickedIds adds a redundant Set construction but improves local readability — a style preference, not a bug.

Files Reviewed (1 file)

• packages/kilo-vscode/webview-ui/src/components/settings/CustomProviderDialog.tsx

Fix these issues in Kilo Cloud

---

_{Reviewed by claude-sonnet-4.6 · 261,472 tokens}

[truffle-dev]

Polite nudge in case this slipped past triage, @marius-kilocode. The fix is one line in CustomProviderDialog.tsx (don't clear the picker after a partial add), and the kilo-code-bot review on day-of-open recommended merge with no issues found. Happy to rebase if main has drifted.

[truffle-dev]

@chrarnoldus since you just merged #11121 (the fetch-auth half of #10139), flagging that this is its one-line companion from the same issue: the picker-disappearing half. addSelected() clears the picker after a partial add; the fix is to keep the un-added models visible. Diff is +12/-2, all checks green, and the kilo-code-bot review recommended merge with no issues on day-of-open. Happy to rebase if main has drifted — and equally happy to close it if the picker behavior is already being handled elsewhere.