Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/session-prompt-queue-memory-leak.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@kilocode/cli": patch
---

Prevent memory leak in KiloSessionPromptQueue.cancel for sessions without active tails
12 changes: 12 additions & 0 deletions packages/opencode/src/kilocode/session/prompt-queue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ export namespace KiloSessionPromptQueue {
const activeSince = new Map<SessionID, number>()
let seq = 0

/** @internal - test-only helper */
export function _hasInternalState(sessionID: SessionID): boolean {
Comment thread
IamCoder18 marked this conversation as resolved.
return versions.has(sessionID) || targets.has(sessionID) || latest.has(sessionID) || activeSince.has(sessionID)
}

const version = (sessionID: SessionID) => versions.get(sessionID) ?? 0
const settle = (promise: Promise<void>) =>
promise.then(
Expand All @@ -36,6 +41,13 @@ export namespace KiloSessionPromptQueue {

export function cancel(sessionID: SessionID) {
return Effect.sync(() => {
if (!tails.has(sessionID)) {
versions.delete(sessionID)
targets.delete(sessionID)
latest.delete(sessionID)
activeSince.delete(sessionID)
return
}
versions.set(sessionID, version(sessionID) + 1)
})
}
Expand Down
19 changes: 19 additions & 0 deletions packages/opencode/test/kilocode/session-prompt-queue.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,25 @@ describe("session prompt queue", () => {
}
})

test("cancel on a session with no active tail is a no-op and does not leak state", async () => {
const sessionID = SessionID.make("session_cancel_noop")

await Effect.runPromise(KiloSessionPromptQueue.cancel(sessionID))

expect(KiloSessionPromptQueue._hasInternalState(sessionID)).toBe(false)

const result = await Effect.runPromise(
KiloSessionPromptQueue.enqueue(
sessionID,
MessageID.make("message_probe"),
Effect.succeed("work executed"),
Effect.succeed("cancelled returned"),
),
)

expect(result).toBe("work executed")
})

test("cancel drops queued prompts and resets internal state", async () => {
const ready = Promise.withResolvers<void>()
const calls: number[] = []
Expand Down
Loading