Skip to content

Feat: adding skill files#26

Merged
markijbema merged 4 commits intoKilo-Org:mainfrom
Neonsy:feat/adding-skill-files
Mar 2, 2026
Merged

Feat: adding skill files#26
markijbema merged 4 commits intoKilo-Org:mainfrom
Neonsy:feat/adding-skill-files

Conversation

@Neonsy
Copy link
Copy Markdown
Contributor

@Neonsy Neonsy commented Feb 23, 2026

  • agent-md-refactor
  • angular-component
  • angular-di
  • angular-directives
  • angular-forms
  • angular-http
  • angular-routing
  • angular-signals
  • angular-ssr
  • angular-testing
  • angular-tooling
  • find-skills
  • frontend-design
  • gemini-king-mode
  • vercel-composition-patterns

@Neonsy Neonsy mentioned this pull request Feb 23, 2026
@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented Feb 23, 2026

Code Review Summary

Status: No New Issues Found | Recommendation: Merge (pending resolution of existing comments)

Overview

This PR adds 13 new skills (10 Angular skills, frontend-design, agent-md-refactor, vercel-composition-patterns), updates skills/marketplace.yaml with all new entries, and fixes metadata.source.path values for vercel-react-best-practices and web-design-guidelines.

All new skill directories have matching marketplace entries. The marketplace.yaml is properly structured with skills organized by category.

The existing inline comments on this PR (context reference inconsistency in vercel-composition-patterns, license concerns for agent-md-refactor and gemini-king-mode, removal of find-skills) remain valid and should be addressed before merge.

Other Observations (not in diff)

Issues found in unchanged code or patterns from upstream sources that cannot receive inline comments:

File Issue
skills/web-design-guidelines/SKILL.md Missing required license field in YAML frontmatter. Per AGENTS.md, license is a required field.
skills/angular-*/SKILL.md, skills/frontend-design/SKILL.md (11 files) license: Complete terms in LICENSE.txt is a non-standard license identifier. The actual LICENSE.txt files contain Apache 2.0. Consider using Apache-2.0 SPDX identifier for consistency with other skills. This pattern comes from upstream sources.
skills/angular-*/SKILL.md, skills/agent-md-refactor/SKILL.md, skills/frontend-design/SKILL.md Missing optional metadata.author field. Adding author attribution (e.g., analogjs, softaworks, anthropic) would improve discoverability and credit.
Files Reviewed (30 files)
  • bin/package-lock.json - Generated file, skipped
  • skills/agent-md-refactor/LICENSE - New file, no issues (existing comment addresses attribution concern)
  • skills/agent-md-refactor/SKILL.md - New file, no issues
  • skills/angular-component/LICENSE.txt - New file, Apache 2.0
  • skills/angular-component/SKILL.md - New file, no issues
  • skills/angular-component/references/component-patterns.md - New file
  • skills/angular-di/LICENSE.txt + SKILL.md + references/ - New files
  • skills/angular-directives/LICENSE.txt + SKILL.md + references/ - New files
  • skills/angular-forms/LICENSE.txt + SKILL.md + references/ - New files
  • skills/angular-http/LICENSE.txt + SKILL.md + references/ - New files
  • skills/angular-routing/LICENSE.txt + SKILL.md + references/ - New files
  • skills/angular-signals/LICENSE.txt + SKILL.md + references/ - New files
  • skills/angular-ssr/LICENSE.txt + SKILL.md + references/ - New files
  • skills/angular-testing/LICENSE.txt + SKILL.md + references/ - New files
  • skills/angular-tooling/LICENSE.txt + SKILL.md + references/ - New files
  • skills/frontend-design/LICENSE.txt + SKILL.md - New files
  • skills/marketplace.yaml - Updated with all new skills, properly ordered
  • skills/vercel-composition-patterns/AGENTS.md - New file (existing comment on line 681)
  • skills/vercel-composition-patterns/LICENSE - New file, MIT
  • skills/vercel-composition-patterns/SKILL.md - New file, well-structured
  • skills/vercel-composition-patterns/rules/*.md (8 files) - New rule files
  • skills/vercel-react-best-practices/SKILL.md - Path fix ✓
  • skills/web-design-guidelines/SKILL.md - Path fix ✓

@Neonsy
Copy link
Copy Markdown
Contributor Author

Neonsy commented Feb 27, 2026

@markijbema It would be nice if this is getting merged at some point 😛

I'm going to resolve the new conflict later, but I don't wanna keep on having to do that, and this has been waiting for 3+ weeks now

@Neonsy Neonsy force-pushed the feat/adding-skill-files branch from 2ebbd10 to 8d38eec Compare February 28, 2026 00:38
Comment thread skills/vercel-composition-patterns/AGENTS.md
Comment thread skills/vercel-composition-patterns/rules/state-lift-state.md
Comment thread skills/gemini-king-mode/LICENSE.txt Outdated
Comment thread skills/agent-md-refactor/LICENSE Outdated
Comment thread skills/find-skills/SKILL.md Outdated
Copy link
Copy Markdown
Contributor

@markijbema markijbema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the license, and remove the two skills indicated. Otherwise this PR is good to go. Thanks!

@Neonsy
Copy link
Copy Markdown
Contributor Author

Neonsy commented Mar 2, 2026

@markijbema Done, unless I missed something.

@markijbema markijbema merged commit e35196e into Kilo-Org:main Mar 2, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants