Repository navigation
feat(auth): offer Continue with ChatGPT on the sign-in screen - #6973
Merged
Merged
Conversation
The sign-in screen renders 'Continue with ChatGPT' with the other OAuth providers on the first screen, before the visitor takes the email step. The ChatGPT access flag needs a person, because its release condition holds the approved email domains. A signed-out visitor has no person, so the button was hidden until the visitor submitted an address. The flag now gates only the BYOK connection surfaces.
iscekic
marked this pull request as ready for review
September 29, 2026 18:33
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Executive SummaryRemoving the Overview
Issue Details (click to expand)WARNING
Files Reviewed (6 files)
No memory-leak risk introduced: the change removes a hook with Fix these issues in Kilo Cloud Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
eshurakov
approved these changes
Sep 29, 2026
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ChatGPT sign-in option to the first sign-in screen.
Change
Continue with ChatGPTin the OAuth provider group, on the first screen and before the email step.sign-in-with-chatgptflag no longer hides the sign-in button. The flag still gates the BYOK card, the sidebar entry, and the BYOK page.useChatGptSignInAccessand its test.Why
The sign-in page cannot read the flag before the visitor types an address: the release condition matches the
emailperson property, and a signed-out visitor has no person. The button therefore appeared only after the email step.Reviewer note
The flag is a UI gate only.
isOpenAiChatGptEligibleForOwnerreads the stored connection and the served model, not the flag. Every visitor can now see the option and connect a ChatGPT plan. If the allow-list must hold on the sign-in path, say so and I will keep the button behind the known address instead.Verification
pnpm --filter web lint— 0 warnings, 0 errors.scripts/typecheck-all.sh --changes-only— pass.SignInForm.signInOptions,SignInForm,auth-touch-targets— 32 tests pass.Continue with ChatGPTbeside the other providers.