fix(ai-gateway): drop reasoning_effort when auto model sets reasoning config - #6949
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe change correctly deletes a client-supplied Files Reviewed (2 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
pandemicsyn
approved these changes
Sep 29, 2026
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an auto model (e.g.
kilo-auto/frontieror a variant-resolvedkilo-auto/efficientdecision) splices areasoningconfig into a chat completions request, any client-suppliedreasoning_effortwas left in the body. Upstream providers can then receive conflicting reasoning settings.applyResolvedAutoModelnow deletesreasoning_effortfrom chat completions bodies whenever it setsreasoning. Requests where the auto model resolves without a reasoning config keep the client'sreasoning_effortunchanged.Verification
pnpm typecheck(apps/web)apps/web/src/lib/ai-gateway/auto-modelapplyResolvedAutoModeltests inresolution.test.ts; test execution left to CI.