Skip to content

(janitor/comments): remove noise comments from platform integrations #6884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pandemicsyn merged 1 commit into from
Sep 29, 2026
Merged

(janitor/comments): remove noise comments from platform integrations #6884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 9 additions & 109 deletions apps/web/src/lib/integrations/platforms/github/adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ export async function fetchGitHubInstallationRequests(
}));
}

/**
* Verifies GitHub webhook signature
* @param appType - The type of GitHub App to verify against (defaults to 'standard')
*/
export function verifyGitHubWebhookSignature(
payload: string,
signature: string,
Expand All @@ -61,10 +57,6 @@ export function verifyGitHubWebhookSignature(
}
}

/**
* Generates GitHub App installation token
* @param appType - The type of GitHub App to use (defaults to 'standard')
*/
export async function generateGitHubInstallationToken(
installationId: string,
appType: GitHubAppType = 'standard',
Expand Down Expand Up @@ -104,10 +96,6 @@ export async function generateGitHubInstallationTokenForMaintenance(
};
}

/**
* Deletes a GitHub App installation
* @param appType - The type of GitHub App to use (defaults to 'standard')
*/
export async function deleteGitHubInstallation(
installationId: string,
appType: GitHubAppType = 'standard'
Expand All @@ -118,7 +106,6 @@ export async function deleteGitHubInstallation(
throw new Error(`GitHub ${appType} App credentials not configured`);
}

// Create app-level authentication (not installation-level)
const auth = createAppAuth({
appId: credentials.appId,
privateKey: credentials.privateKey,
Expand All @@ -127,7 +114,6 @@ export async function deleteGitHubInstallation(
const { token } = await auth({ type: 'app' });
const octokit = new Octokit({ auth: token });

// Delete the installation
await octokit.apps.deleteInstallation({
installation_id: parseInt(installationId),
});
Expand Down Expand Up @@ -194,10 +180,6 @@ type GitHubBranch = {
isDefault: boolean;
};

/**
* Fetches all repositories accessible by a GitHub App installation
* @param appType - The type of GitHub App to use (defaults to 'standard')
*/
export async function fetchGitHubRepositories(
installationId: string,
appType: GitHubAppType = 'standard',
Expand All @@ -212,7 +194,6 @@ export async function fetchGitHubRepositories(
);
const octokit = new Octokit({ auth: tokenData.token });

// Fetch all repositories accessible by the installation using pagination
const repositories: GitHubRepository[] = [];
let page = 1;
const perPage = 100;
Expand All @@ -223,7 +204,6 @@ export async function fetchGitHubRepositories(
page,
});

// Filter out archived repositories
repositories.push(
...data.repositories
.filter(repo => !repo.archived)
Expand Down Expand Up @@ -270,10 +250,6 @@ export async function fetchGitHubRepositoriesForMaintenance(
return repositories;
}

/**
* Fetches all branches for a GitHub repository
* @param appType - The type of GitHub App to use (defaults to 'standard')
*/
export async function fetchGitHubBranches(
installationId: string,
repositoryFullName: string,
Expand All @@ -291,14 +267,12 @@ export async function fetchGitHubBranches(

const [owner, repo] = repositoryFullName.split('/');

// Fetch the repository to get the default branch
const { data: repoData } = await octokit.repos.get({
owner,
repo,
});
const defaultBranch = repoData.default_branch;

// Fetch all branches using pagination
const branches: GitHubBranch[] = [];
let page = 1;
const perPage = 100;
Expand All @@ -325,11 +299,6 @@ export async function fetchGitHubBranches(
return branches;
}

/*
* Fetches GitHub App installation details including permissions
* Uses app-level authentication to get installation info
* @param appType - The type of GitHub App to use (defaults to 'standard')
*/
export async function fetchGitHubInstallationDetails(
installationId: string,
appType: GitHubAppType = 'standard'
Expand All @@ -351,7 +320,6 @@ export async function fetchGitHubInstallationDetails(
throw new Error(`GitHub ${appType} App credentials not configured`);
}

// Create app-level authentication (not installation-level)
const auth = createAppAuth({
appId: credentials.appId,
privateKey: credentials.privateKey,
Expand Down Expand Up @@ -379,9 +347,7 @@ export async function fetchGitHubInstallationDetails(
}

/**
* Adds a reaction to a PR (or issue)
* Used to show that Kilo is reviewing a PR (e.g., 👀 eyes reaction)
* @param appType - The type of GitHub App to use (defaults to 'standard')
* Used to show that Kilo is reviewing a PR (e.g., 👀 eyes reaction).
*/
export async function addReactionToPR(
installationId: string,
Expand Down Expand Up @@ -451,9 +417,7 @@ export async function hasPRCommentWithMarker(
}

/**
* Adds a reaction to a PR review comment
* Used to acknowledge @kilo fix mentions on inline review comments
* @param appType - The type of GitHub App to use (defaults to 'standard')
* Used to acknowledge @kilo fix mentions on inline review comments.
*/
export async function addReactionToPRReviewComment(
installationId: string,
Expand All @@ -475,10 +439,8 @@ export async function addReactionToPRReviewComment(
}

/**
* Checks the collaborator permission level for a user on a repository.
* Returns the permission string ('admin' | 'write' | 'read' | 'none') or null
* if the lookup fails (e.g. the App lacks permission to query collaborators).
* @param appType - The type of GitHub App to use (defaults to 'standard')
*/
export type CollaboratorPermission = 'admin' | 'write' | 'read' | 'none';

Expand Down Expand Up @@ -511,11 +473,6 @@ export async function getCollaboratorPermissionLevel(
}
}

/**
* Replies to a PR review comment thread
* Used by auto-fix to post completion/failure replies on review threads
* @param appType - The type of GitHub App to use (defaults to 'standard')
*/
export async function replyToReviewComment(
installationId: string,
owner: string,
Expand Down Expand Up @@ -546,9 +503,8 @@ const GitHubOAuthTokenResponseSchema = z.object({
});

/**
* Exchange GitHub OAuth code for user information
* Used during installation request flow to identify the GitHub user
* @param appType - The type of GitHub App to use (defaults to 'standard')
* Used during installation request flow to identify the GitHub user.
*
* @param codeVerifier - The PKCE code verifier, required when the
* authorization request that produced `code` included a code_challenge
* (as `beginConnection` does). GitHub rejects redemption of such a code
Expand Down Expand Up @@ -633,11 +589,8 @@ const KILO_REVIEW_COMMENTS_PER_PAGE = 100;
const MAX_KILO_REVIEW_COMMENT_PAGES = 5;

/**
* Finds an existing Kilo review comment on a PR
* Looks for the <!-- kilo-review --> marker in issue comments
* Falls back to detecting older Kilo comments by patterns if no marker found
* Returns the most recent comment ID and body if found, null otherwise
* @param appType - The type of GitHub App to use (defaults to 'standard')
* Looks for the <!-- kilo-review --> marker in issue comments.
* Falls back to detecting older Kilo comments by patterns if no marker found.
*/
export async function findKiloReviewComment(
installationId: string,
Expand Down Expand Up @@ -673,11 +626,9 @@ export async function findKiloReviewComment(
totalComments: comments.length,
});

// Primary: Look for comments with the kilo-review marker
const markedComments = comments.filter(c => c.body?.includes('<!-- kilo-review -->'));

if (markedComments.length > 0) {
// Sort by updated_at descending and pick the latest
const latestComment = markedComments.sort((a, b) => {
return new Date(b.updated_at).getTime() - new Date(a.updated_at).getTime();
})[0];
Expand Down Expand Up @@ -706,10 +657,6 @@ export async function findKiloReviewComment(
return null;
}

/**
* Updates an existing Kilo review comment on a GitHub PR
* Used to append usage footer (model + token count) after review completion
*/
export async function updateKiloReviewComment(
installationId: string,
owner: string,
Expand All @@ -736,9 +683,7 @@ export async function updateKiloReviewComment(
}

/**
* Fetches existing inline review comments on a PR
* Used to detect duplicates and track outdated comments
* @param appType - The type of GitHub App to use (defaults to 'standard')
* Used to detect duplicates and track outdated inline comments.
*/
export async function fetchPRInlineComments(
installationId: string,
Expand Down Expand Up @@ -805,11 +750,6 @@ export async function fetchPRInlineComments(
return comments;
}

/**
* Gets the HEAD commit SHA for a PR
* Required for creating inline comments via gh api
* @param appType - The type of GitHub App to use (defaults to 'standard')
*/
export async function getPRHeadCommit(
installationId: string,
owner: string,
Expand Down Expand Up @@ -1042,9 +982,6 @@ export async function getGitHubReviewComment(
}
}

/**
* Type guard to check if an error is an HTTP error from Octokit
*/
function isHttpError(error: unknown): error is { status: number; message: string } {
return (
typeof error === 'object' &&
Expand Down Expand Up @@ -1278,15 +1215,6 @@ export async function fetchPullRequestReviewDecision(args: {
return results.get('pr0') ?? null;
}

/**
* Get repository details including whether it's empty.
* Used to validate target repo before migration.
*
* @param installationId - The GitHub App installation ID
* @param repoFullName - The full name of the repository (owner/repo)
* @param appType - The type of GitHub App to use (defaults to 'standard')
* @returns Repository details or null if not found/not accessible
*/
export async function getRepositoryDetails(
installationId: string,
repoFullName: string,
Expand All @@ -1312,8 +1240,6 @@ export async function getRepositoryDetails(
repo,
});

// Check if repo is empty by trying to get commits
// An empty repo has no commits
let isEmpty = false;
try {
const { data: commits } = await octokit.repos.listCommits({
Expand Down Expand Up @@ -1345,7 +1271,6 @@ export async function getRepositoryDetails(
isPrivate: repoData.private,
};
} catch (error) {
// 404 means repo doesn't exist or not accessible
if (isHttpError(error) && error.status === 404) {
return null;
}
Expand All @@ -1354,12 +1279,8 @@ export async function getRepositoryDetails(
}

/**
* Get the URL to the GitHub App installation settings page.
* Users may need to grant access to newly created repos here.
*
* @param installationId - The GitHub App installation ID
* @param appType - The type of GitHub App to use (defaults to 'standard')
* @returns The URL to the installation settings page
* The installation settings page is where users grant access to newly
* created repos.
*/
export async function getInstallationSettingsUrl(
installationId: string,
Expand All @@ -1371,7 +1292,6 @@ export async function getInstallationSettingsUrl(
throw new Error(`GitHub ${appType} App credentials not configured`);
}

// Create app-level authentication to get installation details
const auth = createAppAuth({
appId: credentials.appId,
privateKey: credentials.privateKey,
Expand All @@ -1384,24 +1304,15 @@ export async function getInstallationSettingsUrl(
installation_id: parseInt(installationId),
});

// The account type determines the URL format
const accountLogin = (data.account as { login?: string })?.login ?? '';
const accountType = (data.account as { type?: string })?.type ?? 'User';

// GitHub App installation settings URL format
// For orgs: https://github.com/organizations/{org}/settings/installations/{id}
// For users: https://github.com/settings/installations/{id}
if (accountType === 'Organization') {
return `https://github.com/organizations/${accountLogin}/settings/installations/${installationId}`;
}
return `https://github.com/settings/installations/${installationId}`;
}

/**
* Check if user already has a fork of a repository
* @param accountLogin - The GitHub username of the account where the fork would be created
* @param appType - The type of GitHub App to use (defaults to 'standard')
*/
export async function checkExistingFork(
installationId: string,
accountLogin: string,
Expand All @@ -1413,13 +1324,11 @@ export async function checkExistingFork(
const octokit = new Octokit({ auth: tokenData.token });

try {
// Check if the user has a repo with the same name as the source
const { data: repo } = await octokit.repos.get({
owner: accountLogin,
repo: sourceRepo,
});

// Verify it's actually a fork of the source repo
if (repo.fork && repo.parent?.full_name === `${sourceOwner}/${sourceRepo}`) {
return {
exists: true,
Expand All @@ -1431,18 +1340,13 @@ export async function checkExistingFork(
// This is an edge case - the fork will be created with a different name
return { exists: false, fullName: null };
} catch (error) {
// 404 means the repo doesn't exist - no existing fork
if (isHttpError(error) && error.status === 404) {
return { exists: false, fullName: null };
}
throw error;
}
}

// ============================================================================
// Commit Inspection
// ============================================================================

/**
* Checks whether a commit is a merge commit (has 2+ parents).
* Used to skip code reviews triggered by "merge base into feature" pushes.
Expand Down Expand Up @@ -1485,10 +1389,6 @@ export async function isMergeCommit(
}
}

// ============================================================================
// Check Runs API (PR gate checks)
// ============================================================================

/**
* Conclusion values for a completed GitHub Check Run.
* @see https://docs.github.com/en/rest/checks/runs#create-a-check-run
Expand Down
Loading