(janitor/test-prune): remove redundant expectTypeOf assertions in cloud-agent-next tests

[kilo-code-bot]

Summary

Removes four expectTypeOf assertions across two services/cloud-agent-next test files. expectTypeOf (from expect-type, re-exported by Vitest) emits no runtime check — every matcher is () => true — so these assertions can never fail at test-execution time and are pure type-system noise.

Why each removal cannot detect a regression

src/sandbox-state/ports/reconcile.test.ts

• Removed: it('is assignable from the production control transport') — expectTypeOf<SandboxControlSocketHandler['sendRequest']>().toMatchTypeOf<ReconcileSendRequest>().
• Why it cannot fail: toMatchTypeOf is compile-time only. The same one-way assignability is already enforced authoritatively at the production call site persistence/SandboxControl.ts:756 (createReconcilePort(request => this.socketHandler.sendRequest(request))). If sendRequest's signature ever becomes incompatible with ReconcileSendRequest, tsgo fails there — independent of this test. The compile-time expectTypeOf adds no runtime coverage and no compile-time check the production code does not already perform.
• Surviving coverage: the four remaining cases exercise createReconcilePort runtime behavior (phase send with attempt identity/timeout, changed-ack rejection, retryable non-ack, readiness probing).

test/unit/wrapper/kilo-api.test.ts

• Removed: three expectTypeOf(...).toEqualTypeOf<...>() lines (result, prompt, command).
• Why they cannot fail: each compares a value whose declared type is already the generic argument. result = await client.sendPrompt(opts) is typed SessionPromptResponse by sendPrompt's return type, so the assertion is expectTypeOf<SessionPromptResponse>().toEqualTypeOf<SessionPromptResponse>() — T vs T, which is trivially true and provides no compile-time or runtime signal.
• Surviving coverage: the same tests retain their runtime assertions (expect(result).toEqual(completion), expect(prompt.info.error).toEqual(failedCompletion.info.error), expect(command).toEqual(failedCompletion), etc.), which verify the actual values.

Verification

• pnpm exec vitest run src/sandbox-state/ports/reconcile.test.ts test/unit/wrapper/kilo-api.test.ts — 54 passing (was 55; the one removed test was the expectTypeOf-only case).
• pnpm exec tsgo --noEmit (cloud-agent-next) — passes.
• pnpm -w exec oxlint --config .oxlintrc.json <two files> — 0 errors / 0 warnings.

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Test-only cleanup removing four compile-time-only expectTypeOf assertions; the removed imports (SandboxControlSocketHandler, SessionCommandResponse) and assertions are genuinely redundant, and no runtime behavior is affected.

Files Reviewed (2 files)

• services/cloud-agent-next/src/sandbox-state/ports/reconcile.test.ts
• services/cloud-agent-next/test/unit/wrapper/kilo-api.test.ts

---

_{Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0}

_{Review guidance: REVIEW.md from base branch main}