feat(web): add batched feedback submission over tRPC and HTTP with a per-minute limit - #6864
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe follow-up commit makes the feedback rate-limit read and insert atomic by wrapping both in one transaction under a per-user transaction-scoped Files Reviewed (1 file)
Previous Review Summary (commit 32e84e8)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 32e84e8)Status: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (9 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
iscekic
marked this pull request as draft
September 29, 2026 06:54
iscekic
marked this pull request as ready for review
September 29, 2026 15:27
pandemicsyn
approved these changes
Sep 29, 2026
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
feedback.submitmutation and the HTTPPOST /feedbackendpoint.userFeedback.createmutation now shares the same storage and the same one-per-minute limit.Changelog for maintainers
user_feedbackPostgreSQL table; this app has no D1 or R2 binding.feedback.submit; the checked-in skill is generated from its template, so regenerate both together.E2E proof
[MCP] initialize instructions, tool-call errors, and the catalog point agents at the batched feedback endpoint
Asserted value:
KWF_MCP feedback pointer present=true. Sense check (jev): probability 0.95Base log: backend-assert 41a25bc7941d exited 1
Head log: backend-assert 41a25bc7941d exited 0
[tRPC] feedback.submit stores one submission and refuses a second within a minute
Asserted value:
KWF_FEEDBACK rate-limit code=TOO_MANY_REQUESTS rows=1 router_present=true. Sense check (jev): probability 0.92Base log: backend-assert 2b5062d148e8 exited 1
Head log: backend-assert 2b5062d148e8 exited 0
[HTTP] POST /feedback refuses unauthenticated callers, stores a submission, and returns 429 with the batching message
Asserted value:
KWF_FEEDBACK_HTTP rate-limit first=200 second=429 unauth=401 rows=1 route_present=true. Sense check (jev): probability 0.94Base log: backend-assert 25c87e172f8a exited 1
Head log: backend-assert 25c87e172f8a exited 0
Owner request