fix(mobile): keep a disabled composer and name the continue destination in read-only sessions - #6862
Merged
Conversation
…on in read-only sessions
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the read-only composer change (always-mount with Files Reviewed (90 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
chrarnoldus
approved these changes
Sep 29, 2026
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
E2E proof
[U2] continue-in-new-session label is present in every locale catalog
Asserted value:
locales checked: 87, missing: 0. Sense check (jev): probability 0.91Base log: backend-assert 7ef044fc6a63 exited 1
Head log: backend-assert 7ef044fc6a63 exited 0
[D1][U2] read-only session keeps a disabled composer with the reason and names the continue destination
Asserted value:
read-only session: disabled composer with the continue-in-new-session control. Sense check (model): Head ui-assert 3b515baa87ec exits 0 naming 'read-only session: disabled composer with the continue-in-new-session control' and 'shown: Continue in a new session', while the base fails with 'Continue in a new session -> not shown (exit 1)' and the head screens show the dimmed composer under 'This is a read-only session' plus the Continue screen 'Continuing 60-message pagination fixture'.da3426980f96c1aeeaae6a83After ui-assert: the read-only 60-message session with 'This is a read-only session' above the dimmed disabled composer at the bottom and the 'Continue in a new session' control
da3426980f96c1aeeaae6a83After ui-assert: the Continue screen headed 'Continuing 60-message pagination fixture' with Mode, Model, Run on and Repository
Base log: ui-assert 3b515baa87ec exited 1
Base log: ui-assert 66852459f603 exited 1
Head log: ui-assert 3b515baa87ec exited 0
Head log: ui-assert 66852459f603 exited 0
Owner request