(janitor/comments) remove narration and redundant comments from deploy-infra builder - #6777
Merged
Merged
Conversation
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThis PR removes narration and redundant comments (636 deletions, 4 trailing-comment-only line edits) across the deploy-infra builder service, and verification shows no behavior, type, or API changes. Verification
Files Reviewed (16 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
pandemicsyn
approved these changes
Sep 28, 2026
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(janitor/comments) Comment cleanup —
services/deploy-infra/builderPackage or topic area cleaned
services/deploy-infra/builder— the Cloudflare Worker builder service for user deployments (Durable Objects, Cloudflare API client, sandbox readers, webhook delivery, event store, and its unit tests).Files touched (16)
src/index.tssrc/types.tssrc/event-store.tssrc/events-manager.tssrc/webhook-delivery.tssrc/deployment-orchestrator.tssrc/cloudflare-api.tssrc/deployer.tssrc/sandbox-file-reader.tssrc/sandbox-artifact-reader.tssrc/env-decryptor.tssrc/sanitize-git-error.tssrc/utils.tsscripts/deploy-local.tssrc/tests/webhook-delivery.test.tssrc/tests/sanitize-git-error.test.tsComment lines removed
632 comment lines (636 deleted lines total; 4 of them are code lines that only lost a trailing comment). No behavior, types, or APIs changed.
Categories of noise removed
/** Save current state to durable storage. */,@param/@returnsblocks that mirror signatures)// Text/// Imagesseparators)supportedProjectTypeSchemadoc missingastro; doc referencing a removedbatchSizeparameter)Important comments intentionally retained
replaceAllinstead of regex insanitizeGitError; "Environment variables (only non-secret)" contract ondeployWorkersandbox.readFileStream10MB workaround, alarm usage rationale, in-memory reentrancy guard safe because requests are cancelled on sleep,COPYFILE_DISABLEfor macOS tar-1/0sentinel values, "All events have been processed", exit-code decode for the Git LFS probe, "no backend URL → skip sending", backup buffer cleanup "may not have been extracted yet"COPYFILE_DISABLEexclusion-list annotations and the sandbox-exec hang TODO (documents a live platform limitation; the disabled script is retained as-is)Follow-up refactor candidates
WebhookDelivery.scheduleFlush— the retry/overflow/batch-timing phases rely on comment labels; extracting named phases would remove the need for them.EventStore.getFirstUnprocessedEventIndex— index arithmetic (lastProcessedId - firstEventId + 1) is subtle; a helper or named computation would make the remaining comments unnecessary.Validation performed
pnpm typecheck(tsgo --noEmit) — passpnpm lint(oxlint, 34 files) — 0 warnings, 0 errorspnpm test(jest) — 9 suites, 103 tests, all passgit diff --check— clean