fix(notifications): translate the spend-alert push text - #6767
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (82 files)
Previous Review Summary (commit 6665f1a)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 6665f1a)Status: No Issues Found | Recommendation: Merge Executive SummaryTranslation-only change across all 86 non-English notification locales; the three spend-alert strings are translated, every locale file parses as JSON, and both Verification performed:
Files Reviewed (86 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
iscekic
added
merge-by-human
iscekic
marked this pull request as draft
September 28, 2026 08:42
iscekic
marked this pull request as ready for review
September 28, 2026 08:45
iscekic
marked this pull request as draft
September 28, 2026 08:53
iscekic
marked this pull request as ready for review
September 28, 2026 09:06
iscekic
marked this pull request as draft
September 28, 2026 09:18
iscekic
marked this pull request as ready for review
September 28, 2026 09:30
pandemicsyn
approved these changes
Sep 28, 2026
iscekic
marked this pull request as draft
September 28, 2026 21:28
Collaborator
Author
|
bot: Fixed the main merge in 00825b0. |
…ions-push-1a0d360065 # Conflicts: # packages/notifications/src/locales/hi.json # packages/notifications/src/locales/ht.json
Collaborator
Author
|
bot: Fixed the main merge in baf3bf2. |
iscekic
marked this pull request as ready for review
September 28, 2026 21:58
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix proof
The Basque spend-alert push body is still English:
generic.body.spendAlertrenders "Your spend needs attention" on the lock screen, becausegenericPushContentForPushDataresolves that key for a `sAsserted value:
packages/notifications/src/locales/eu.json. Sense check (model): eu.json:10 now maps generic.body.spendAlert to the Basque "Zure gastuak arreta behar du" (and the related spend-alert title/body), the exact key genericPushContentForPushData reads for a spend_alert push, fixing the English lock-screen body.The scripts were proven on an earlier base, so only the head ran.
Head log: backend-assert 0ebe120d074a exited 0
The Basque owner-facing spend-alert push is still English:
internal.spendAlert.title("Spend alert") and.body("{{scopeName}} spend crossed ${{amountUsd}}") are resolved by NotificationChannelDO.Asserted value:
packages/notifications/src/locales/eu.json. Sense check (model): The eu.json lines translate the exact internal.spendAlert title/body keys the claim says resolve to EnglishThe scripts were proven on an earlier base, so only the head ran.
Head log: backend-assert 0ebe120d074a exited 0
The Serbian spend-alert push body is still English:
generic.body.spendAlertrenders "Your spend needs attention" on the lock screen for aspend_alertpush (push-presentation.ts:341-350); every sibAsserted value:
packages/notifications/src/locales/sr.json. Sense check (model): sr.json:10 now reads "spendAlert": "Vaša potrošnja zahteva pažnju", replacing the English "Your spend needs attention" that the claim names for generic.body.spendAlert.The scripts were proven on an earlier base, so only the head ran.
Head log: backend-assert f193a3b02b77 exited 0
The Serbian owner-facing spend-alert push is still English:
internal.spendAlert.title("Spend alert") and.body("{{scopeName}} spend crossed ${{amountUsd}}") are resolved by NotificationChannelDOAsserted value:
packages/notifications/src/locales/sr.json. Sense check (model): sr.json adds the Serbian translations "Upozorenje o potrošnji" and "Potrošnja za {{scopeName}} prešla je ${{amountUsd}}" for the exact internal.spendAlert title/body keys the claim names, replacing the English strings.The scripts were proven on an earlier base, so only the head ran.
Head log: backend-assert f193a3b02b77 exited 0
Fix proof
The Basque spend-alert push body is still English:
generic.body.spendAlertrenders "Your spend needs attention" on the lock screen, becausegenericPushContentForPushDataresolves that key for a `sAsserted value:
packages/notifications/src/locales/eu.json. Sense check (model): eu.json:10 now reads "spendAlert": "Zure gastuak arreta behar du", translating the key the claim names.The scripts were proven on an earlier base, so only the head ran.
Head log: backend-assert 3aec0afd5e3d exited 0
The Basque owner-facing spend-alert push is still English:
internal.spendAlert.title("Spend alert") and.body("{{scopeName}} spend crossed ${{amountUsd}}") are resolved by NotificationChannelDO.Asserted value:
packages/notifications/src/locales/eu.json. Sense check (model): eu.json:10 now translates spendAlert.title to "Gastu-alerta" and .body to "{{scopeName}} gastuak ${{amountUsd}} gainditu du", the exact keys the claim says stay English for Basque spend_alert pushes.The scripts were proven on an earlier base, so only the head ran.
Head log: backend-assert 3aec0afd5e3d exited 0
The Serbian spend-alert push body is still English:
generic.body.spendAlertrenders "Your spend needs attention" on the lock screen for aspend_alertpush (push-presentation.ts:341-350); every sibAsserted value:
packages/notifications/src/locales/sr.json. Sense check (model): The diff changes sr.json:10 "spendAlert" from "Your spend needs attention" to "Vaša potrošnja zahteva pažnju", exactly the English body string the claim names.The scripts were proven on an earlier base, so only the head ran.
Head log: backend-assert d132d35c75e1 exited 0
The Serbian owner-facing spend-alert push is still English:
internal.spendAlert.title("Spend alert") and.body("{{scopeName}} spend crossed ${{amountUsd}}") are resolved by NotificationChannelDOAsserted value:
packages/notifications/src/locales/sr.json. Sense check (model): sr.json diff replaces the English "title": "Spend alert" and "body": "{{scopeName}} spend crossed ${{amountUsd}}" with Serbian, fixing the untranslated internal.spendAlert keys the claim namesThe scripts were proven on an earlier base, so only the head ran.
Head log: backend-assert d132d35c75e1 exited 0
Changelog for users
Changelog for maintainers
E2E proof
The Basque spend-alert push body is still English:
generic.body.spendAlertrenders "Your spend needs attention" on the lock screen, becausegenericPushContentForPushDataresolves that key for aspend_alertpush (push-presentation.ts:341-350). Every siblinggeneric.body.*is translated in eu.json; only spendAlert was left in English.Code trace:
packages/notifications/src/locales/eu.json:10 changed in f3ee3e8dfe3491148926a714b2a7fcf4c44a2314. Sense check (model): The diff changes the traced key at eu.json to "spendAlert": "Zure gastuak arreta behar du", directly fixing the English body the claim names.Changed lines
The Basque owner-facing spend-alert push is still English:
internal.spendAlert.title("Spend alert") and.body("{{scopeName}} spend crossed ${{amountUsd}}") are resolved by NotificationChannelDO.ts:287-298 forspend_alertpushes, while the siblinginternal.lowBalanceandinternal.securityFinding*keys are translated, so the Basque billing owner gets an English notification.Code trace:
packages/notifications/src/locales/eu.json:10 changed in f3ee3e8dfe3491148926a714b2a7fcf4c44a2314. Sense check (model): eu.json diff replaces the flagged English "title": "Spend alert" and body string with Basque values, fixing the named spend-alert keysChanged lines
The Serbian spend-alert push body is still English:
generic.body.spendAlertrenders "Your spend needs attention" on the lock screen for aspend_alertpush (push-presentation.ts:341-350); every siblinggeneric.body.*is translated in sr.json, only spendAlert was left in English.Code trace:
packages/notifications/src/locales/sr.json:10 changed in f3ee3e8dfe3491148926a714b2a7fcf4c44a2314. Sense check (model): sr.json:10 now reads "spendAlert": "Vaša potrošnja zahteva pažnju", replacing the English string the claim namesChanged lines
The Serbian owner-facing spend-alert push is still English:
internal.spendAlert.title("Spend alert") and.body("{{scopeName}} spend crossed ${{amountUsd}}") are resolved by NotificationChannelDO.ts:287-298 while the sibling internal keys are translated, so the Serbian billing owner gets an English notification.Code trace:
packages/notifications/src/locales/sr.json:10 changed in f3ee3e8dfe3491148926a714b2a7fcf4c44a2314. Sense check (model): sr.json diff replaces the English "title":"Spend alert" and "body":"{{scopeName}} spend crossed ${{amountUsd}}" with Serbian translations, the exact keys the claim namesChanged lines
Owner request