Repository navigation
fix(mobile): announce the selected state in repository and mode pickers - #6763
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous Review Summary (commit 7c54feb)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 7c54feb)Status: No Issues Found | Recommendation: Merge Both pickers now expose Files Reviewed (2 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
Collaborator
Author
|
bot: Fixed failing checks in e68732c. |
iscekic
marked this pull request as draft
September 28, 2026 08:41
iscekic
marked this pull request as ready for review
September 28, 2026 08:45
iscekic
marked this pull request as draft
September 28, 2026 08:53
iscekic
marked this pull request as ready for review
September 28, 2026 09:02
iscekic
marked this pull request as draft
September 28, 2026 09:06
iscekic
marked this pull request as ready for review
September 28, 2026 09:11
iscekic
marked this pull request as draft
September 28, 2026 09:18
iscekic
marked this pull request as ready for review
September 28, 2026 09:29
pandemicsyn
approved these changes
Sep 28, 2026
iscekic
enabled auto-merge (squash)
September 28, 2026 21:27
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix proof
The single-select repository and mode picker rows expose no selected/checked accessibility state, so a screen-reader user cannot tell which repository or mode is currently chosen, unlike the branch, i
Asserted value:
apps/mobile/src/app/(app)/agent-chat/repo-picker.tsx. Sense check (model): added lineaccessibilityState={{ selected: isSelected }}in repo-picker.tsx supplies the missing selected state the claim describesThe scripts were proven on an earlier base, so only the head ran.
Head
e68732ceb00aHead log: backend-assert bbcddcd77ec8 exited 0
Changelog for users
Changelog for maintainers
E2E proof
The single-select repository and mode picker rows expose no selected/checked accessibility state, so a screen-reader user cannot tell which repository or mode is currently chosen, unlike the branch, instance and profile pickers which announce it.
Code trace:
apps/mobile/src/app/(app)/agent-chat/repo-picker.tsx:180 changed in a7db6a847417cd02b0a1ada04c53ac875013c178. Sense check (model): The added lineaccessibilityState={{ selected: isSelected }}on the repo-picker row exposes the selected state the claim says is missingChanged lines
Owner request