Skip to content

fix(mobile): correct the pull request term in Polish and Sinhala - #6742

Merged
iscekic merged 3 commits into
mainfrom
kwf/janitor-mobile-common-cfd22e2f6d
Sep 28, 2026
Merged

iscekic merged 3 commits into
mainfrom
kwf/janitor-mobile-common-cfd22e2f6d

Conversation

@iscekic

@iscekic iscekic commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Fix proof

The pull-request term renders as 'pR' in three Polish keys — as the link label, the session chip 'pR {{number}}', and the sentence-initial 'pR zmienił się…' — which is broken casing/term for 'PR'.

Asserted value: apps/mobile/src/i18n/locales/pl.json. Sense check (jev): probability 0.96

The scripts were proven on an earlier base, so only the head ran.

Head 6d58aef8c2fb

Head log: backend-assert c9616fe3a62f exited 0
$ git diff --unified=0 7346ba209c8f1702aaa9322a16337b943d0dda5b 6d58aef8c2fbfd1a49659e3c07fa5a9a03a7a5b5 -- apps/mobile/src/i18n/locales/pl.json
diff --git a/apps/mobile/src/i18n/locales/pl.json b/apps/mobile/src/i18n/locales/pl.json
--- a/apps/mobile/src/i18n/locales/pl.json
+++ b/apps/mobile/src/i18n/locales/pl.json
-    "pullRequest": "pR",
+    "pullRequest": "PR",
@@ -1567 +1567 @@
-      "pullRequest": "pR {{number}}"
+      "pullRequest": "PR {{number}}"
@@ -2948 +2948 @@
-      "staleHint": "pR zmienił się od czasu napisania tego komentarza.",
+      "staleHint": "PR zmienił się od czasu napisania tego komentarza.",

common.pullRequest renders as 'pR' (lowercase p, capital R) — a nonsense token — as the external-URL label and mid-sentence noun in Sinhala, where the rest of the catalog says 'පුල් ඉල්ලීම' or 'PR'.

Asserted value: apps/mobile/src/i18n/locales/si.json. Sense check (jev): probability 0.94

The scripts were proven on an earlier base, so only the head ran.

Head 6d58aef8c2fb

Head log: backend-assert 0a69d0a44c35 exited 0
$ git diff --unified=0 7346ba209c8f1702aaa9322a16337b943d0dda5b 6d58aef8c2fbfd1a49659e3c07fa5a9a03a7a5b5 -- apps/mobile/src/i18n/locales/si.json
diff --git a/apps/mobile/src/i18n/locales/si.json b/apps/mobile/src/i18n/locales/si.json
--- a/apps/mobile/src/i18n/locales/si.json
+++ b/apps/mobile/src/i18n/locales/si.json
@@ -42 +42 @@
-    "pullRequest": "pR",
+    "pullRequest": "පුල් ඉල්ලීම",
@@ -776 +776 @@
-      "pullRequest": "PR",
+      "pullRequest": "පුල් ඉල්ලීම",

Changelog for users

  • Polish now shows "PR" instead of "pR" as the pull-request link label, the session chip, and the stale-comment hint.
  • Sinhala now shows "පුල් ඉල්ලීම" for the pull-request label instead of the nonsense token "pR".

Changelog for maintainers

  • Both locale catalogs change only the pull-request value; the Polish session chip keeps its {{number}} placeholder.
  • The Sinhala value now matches the wording the rest of that catalog already uses for pull request.
  • Check other locale catalogs for the same "pR" token, since this change covers only Polish and Sinhala.

E2E proof

The pull-request term renders as 'pR' in three Polish keys — as the link label, the session chip 'pR {{number}}', and the sentence-initial 'pR zmienił się…' — which is broken casing/term for 'PR'.

Code trace: apps/mobile/src/i18n/locales/pl.json:42 changed in 91a045f3aed12f01f8a8f90f38349ed4afb85c7a. Sense check (jev): probability 0.96

Changed lines
-    "pullRequest": "pR",
+    "pullRequest": "PR",
-      "pullRequest": "pR {{number}}"
+      "pullRequest": "PR {{number}}"
-      "staleHint": "pR zmienił się od czasu napisania tego komentarza.",
+      "staleHint": "PR zmienił się od czasu napisania tego komentarza.",

common.pullRequest renders as 'pR' (lowercase p, capital R) — a nonsense token — as the external-URL label and mid-sentence noun in Sinhala, where the rest of the catalog says 'පුල් ඉල්ලීම' or 'PR'.

Code trace: apps/mobile/src/i18n/locales/si.json:42 changed in 91a045f3aed12f01f8a8f90f38349ed4afb85c7a. Sense check (jev): probability 0.94

Changed lines
-    "pullRequest": "pR",
+    "pullRequest": "පුල් ඉල්ලීම",
Owner request

Fix 2 janitor findings in mobile/common. Fix every one; the proof covers each.

  1. The pull-request term renders as 'pR' in three Polish keys — as the link label, the session chip 'pR {{number}}', and the sentence-initial 'pR zmienił się…' — which is broken casing/term for 'PR'.
    Trace: apps/mobile/src/i18n/locales/pl.json:42: The pull-request term renders as 'pR' in three Polish keys — as the link label, the session chip 'pR {{number}}', and the sentence-initial 'pR zmienił się…' — which is broken casing/term for 'PR'. (janitor area i18n, locale pl).
    Files: apps/mobile/src/i18n/locales/pl.json.
  2. common.pullRequest renders as 'pR' (lowercase p, capital R) — a nonsense token — as the external-URL label and mid-sentence noun in Sinhala, where the rest of the catalog says 'පුල් ඉල්ලීම' or 'PR'.
    Trace: apps/mobile/src/i18n/locales/si.json:42: common.pullRequest renders as 'pR' (lowercase p, capital R) — a nonsense token — as the external-URL label and mid-sentence noun in Sinhala, where the rest of the catalog says 'පුල් ඉල්ලීම' or 'PR'. (janitor area i18n, locale si).
    Files: apps/mobile/src/i18n/locales/si.json.

@kilo-code-bot

kilo-code-bot Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Incremental review of 6d58aef8 found no new issues. The only PR-specific change since the prior review is the Sinhala prReview.terms.pullRequest value, which now equals common.pullRequest (පුල් ඉල්ලීම), satisfying the single-wording rule enforced by pnpm check:i18n; the Polish values unchanged since the prior review remain consistent (PR, PR {{number}}, sentence-initial PR).

Files Reviewed (2 files)
  • apps/mobile/src/i18n/locales/pl.json
  • apps/mobile/src/i18n/locales/si.json
Previous Review Summary (commit 0b9bff8)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 0b9bff8)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • apps/mobile/src/i18n/locales/pl.json
  • apps/mobile/src/i18n/locales/si.json

The changed values keep their placeholder sets intact (PR {{number}}), the Sinhala value matches the wording already used elsewhere in that catalog, and the edits do not introduce a duplicate-copy or alphabet violation in pnpm check:i18n.


Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@iscekic iscekic added merge-by-bot kwf-janitor Admitted to the workflow from a janitor finding labels Sep 26, 2026
@iscekic iscekic self-assigned this Sep 28, 2026
@iscekic
iscekic marked this pull request as draft September 28, 2026 10:31
@iscekic

iscekic commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author

bot: Fixed failing checks in 6d58aef.

@iscekic
iscekic marked this pull request as ready for review September 28, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kwf-janitor Admitted to the workflow from a janitor finding merge-by-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants