Repository navigation
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge This test-only change corrects the stale Files Reviewed (1 file)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red. This PR unblocks the failing
test (kilo-app)check.What broke
Workflow run 36167796688, job
test (kilo-app), fails in apps/mobile/src/components/home/home-screen.mounted.test.tsx at line 668, in the testHome live presentation > withholds the platform pull indicator while the live section shows its own loading card:Which commit broke it
Commit f1faf00 (PR #6705) moved the live-session placeholder geometry. The class
min-h-[72px]is now on the wrappingViewof the placeholder card, not on aSkeleton:Why the assertion can never pass
The assertion
nodes('Skeleton')[0]?.props.classNamecontainsmin-h-[72px]is now false by construction. NoSkeletoncarries that class. The firstSkeletonis the 3px leading strip, so the assertion readsabsolute left-0 top-0 bottom-0 w-[3px] rounded-[2px]and fails on every run.PR #6705 updated this assertion pattern in the other sites of the same file to
nodes('View').some(...). Line 668 stayed on the old pattern.The fix
One assertion, corrected to the style already used by the other assertions in the same file. No production code change. No test refactor.
The assertion keeps its meaning: in the pending state
liveSessionContentreturnspending, so the onlymin-h-[72px]card on the surface is the section's own loading placeholder.Verification
Remote CI is the proof. The
test (kilo-app)check must pass on this PR.oxfmt --checkandoxlintare clean on the changed file.