Skip to content

fix(mobile): name the stored-session link on the Agents tab header - #6712

Merged
iscekic merged 14 commits into
mainfrom
kwf/explorer-3-visual-defects-on-ios-see-all-is-offered-in-th-5e249-a5f0
Sep 28, 2026
Merged

iscekic merged 14 commits into
mainfrom
kwf/explorer-3-visual-defects-on-ios-see-all-is-offered-in-th-5e249-a5f0

Conversation

@iscekic

@iscekic iscekic commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Changelog for users

  • The Agents tab header link names the stored-session list instead of claiming “See all” when no agent is live.
  • Arabic search placeholders align with their right-to-left fields in the model and repository pickers.
  • The new catalog key is translated into every locale.

Verification

  • Unit and mounted tests cover the header label and right-to-left picker alignment.
  • No iOS device proof: device verification was blocked because the login probe failed on a non-English pre-auth screen.

…ead of claiming "See all" (kwf explorer-3-visual-defects-on-ios-see-all-is-offered-in-th-5e249-a5f0/s1)
…3-visual-defects-on-ios-see-all-is-offered-in-th-5e249-a5f0/s2)
@kilo-code-bot

kilo-code-bot Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The only change since the previously reviewed commit b8d9ef46 is the merge of origin/main (head now cdc442fc); no PR-authored code changed, and the previously verified Agents-tab header label and RTL picker fixes remain intact.

Files Reviewed (0 PR-authored files changed since last review)
  • No PR-authored files changed since b8d9ef46. The merge only advanced main (upstream session-list-screen skeleton/poll refactor, slash-command catalog keys, and SBOM/release tooling); those changes already live on the base branch and are outside this PR's authored diff.
Previous Review Summaries (5 snapshots, latest commit b8d9ef4)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit b8d9ef4)

Status: No Issues Found | Recommendation: Merge

Executive Summary

The only change since the previously reviewed commit b8de237 is a clean merge of origin/main; the incremental diff contains no PR-authored code, so the previously verified mobile header and picker fixes remain intact and no new defects were found.

Files Reviewed (0 PR-authored files changed since last review)
  • No PR-authored files changed since b8de237. The merge of origin/main brought upstream apps/web coding-plans and a home-screen test change that are already part of the base branch and are not part of this PR's diff.

Previous review (commit b8de237)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Re-reviewed the incremental change since b8a319d (commit b8de237): the picker search fields no longer re-apply withRtlInputAlignment at the call sites, because the shared single-line Input already injects the RTL alignment, so wrapping it twice nested the style array. Removing the call-site wrap is behavior-preserving for the effective style and no defects were found.

Files Reviewed (2 files)
  • apps/mobile/src/app/(app)/agent-chat/repo-picker.tsx
  • apps/mobile/src/components/agents/model-picker-content.tsx

Previous review (commit b8a319d)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Re-reviewed the incremental change since f0ddb38: the picker-search mount test now declares a single hoisted I18nManager mock, resolving the duplicate declaration introduced while merging origin/main. No defects were found.

Files Reviewed (1 file)
  • apps/mobile/src/components/agents/picker-search.mounted.test.tsx

Previous review (commit f0ddb38)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Re-reviewed the three commits added after the previous review (1e7ed6ec): the Agents history label now renders through Eyebrow with its LTR-only letterspacing gate, and the picker mount tests use a mutable I18nManager mock with typed react-test-renderer props. The changes are consistent with Text's existing eyebrow variant and no defects were found.

Files Reviewed (3 files)
  • apps/mobile/src/components/agents/session-list-screen.tsx
  • apps/mobile/src/components/agents/model-picker-content.mounted.test.tsx
  • apps/mobile/src/components/agents/picker-search.mounted.test.tsx

Previous review (commit 1e7ed6e)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the Agents-tab header label rename to agents.sessionList.pastSessions, the RTL input-alignment and placeholder-overlay changes in both pickers, the parity-test update, and the new key landed across all 87 catalogs; the changes are consistent, the new key sits under agents.sessionList in every locale, and no defects were found.

Notes

  • withRtlInputAlignment and EYEBROW_LATIN_DISPLAY resolve to existing exports (apps/mobile/src/lib/rtl-text.ts, apps/mobile/src/components/ui/text.tsx:61), so the new imports are valid.
  • The LTR class output is unchanged (EYEBROW_LATIN_DISPLAY is exactly the previously inlined uppercase tracking-[1.5px]), and RTL drops it as intended.
  • All 87 locale files contain exactly one pastSessions key, correctly nested under agents.sessionList; no duplicate/cannibalized keys and PENDING_TRANSLATION_KEYS is now empty.
  • The PR description still marks findings 2 and 3 as unfixed, but the diff does add the RTL alignment for the model and repository pickers; the description appears stale rather than the code being incomplete.
Files Reviewed (96 files)
  • apps/mobile/src/components/agents/session-list-screen.tsx
  • apps/mobile/src/app/(app)/agent-chat/repo-picker.tsx
  • apps/mobile/src/components/agents/model-picker-content.tsx
  • apps/mobile/src/i18n/catalog-parity.test.ts
  • apps/mobile/src/components/agents/session-list-screen.mounted.test.tsx
  • apps/mobile/src/components/agents/picker-search.mounted.test.tsx
  • apps/mobile/src/components/agents/model-picker-content.mounted.test.tsx
  • apps/mobile/src/components/agents/session-list-screen.pull-failure.mounted.test.tsx
  • apps/mobile/src/components/agents/agents-tab-badge.test-helpers.ts
  • apps/mobile/src/i18n/locales/*.json (87 catalogs, one agents.sessionList.pastSessions entry each)

Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

The main merge moved the header link onto the Eyebrow element; keep the PR's interface-direction gate for the letterspaced capitals.
@iscekic iscekic added the human-ready The PR is ready for human review. label Sep 25, 2026
…-defects-on-ios-see-all-is-offered-in-th-5e249-a5f0

One conflict in picker-search.mounted.test.tsx: both sides append alignment cases after the same line. Keep both blocks. Main's style-shape cases and this branch's direction cases assert the same withRtlInputAlignment contract, and the merged implementation satisfies both. The max-lines header keeps main's wording.
…ch test

Both sides of the main merge added the same hoisted I18nManager mock, so the merged file declared i18nManager twice and broke typecheck and lint. Keep the first declaration.
…fields

The shared single-line Input already applies withRtlInputAlignment, so the call-site wrap nests the style array and the query-alignment cases on main fail. Keep the picker box and overlay classes from this branch and let the shared Input own the alignment.
…-defects-on-ios-see-all-is-offered-in-th-5e249-a5f0
@iscekic
iscekic marked this pull request as draft September 25, 2026 20:10
@iscekic
iscekic marked this pull request as ready for review September 25, 2026 20:10
…-defects-on-ios-see-all-is-offered-in-th-5e249-a5f0

# Conflicts:
#	apps/mobile/src/components/agents/session-list-screen.tsx
#	apps/mobile/src/i18n/catalog-parity.test.ts
@iscekic
iscekic marked this pull request as draft September 26, 2026 01:57
@iscekic
iscekic marked this pull request as ready for review September 26, 2026 01:57
@iscekic iscekic added merge-by-human the merge bot routed this PR to a human merge-by-bot and removed human-ready The PR is ready for human review. merge-by-human the merge bot routed this PR to a human labels Sep 26, 2026
…-defects-on-ios-see-all-is-offered-in-th-5e249-a5f0
…-defects-on-ios-see-all-is-offered-in-th-5e249-a5f0

# Conflicts:
#	apps/mobile/src/components/agents/session-list-screen.tsx
#	apps/mobile/src/i18n/catalog-parity.test.ts
…-defects-on-ios-see-all-is-offered-in-th-5e249-a5f0

# Conflicts:
#	apps/mobile/src/i18n/catalog-parity.test.ts
@iscekic
iscekic merged commit c5f99ba into main Sep 28, 2026
28 checks passed
@iscekic
iscekic deleted the kwf/explorer-3-visual-defects-on-ios-see-all-is-offered-in-th-5e249-a5f0 branch September 28, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants