Skip to content

(janitor/comments) Remove section banner comments in auto-routing-benchmark - #6633

Merged
kilo-code-bot[bot] merged 1 commit into
mainfrom
janitor/comments-auto-routing-benchmark
Sep 25, 2026
Merged

kilo-code-bot[bot] merged 1 commit into
mainfrom
janitor/comments-auto-routing-benchmark

Conversation

@kilo-code-bot

@kilo-code-bot kilo-code-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Package or topic area cleaned

services/auto-routing-benchmark (auto-routing benchmark service)

Files touched

File Comment lines removed
src/datasets/decider-cases.ts 60
src/datasets/classifier-cases.ts 54
src/db.ts 27
src/admin.test.ts 29
src/profiles.test.ts 15
src/db.test.ts 9

Total: 193 comment lines removed (plus 25 blank lines that directly resulted), 218 deletions, 0 insertions.

Categories of noise removed

  • Section banner separators: every // ------ dashed separator pair in the package (76 blocks).
  • Banner titles restating adjacent code: dataset banners ("implementation / feature_development") duplicating the taskType/subtaskType fields of the cases directly below and the <taskType>-<subtype>-<topic> id convention; test banners ("Setup", "Auth guard", "GET /admin/config", "mapRunRow", "lookupProfileStatuses") duplicating the immediately following describe(...) name; production banners ("Row mapping helpers", "Config", "Case results", "Model summaries", "Classifier winner") labeling groups whose function names already say so. The db.test.ts "mapSummaryRow" banner was also stale — it sat above describe('variant storage helpers').

Important comments intentionally retained

  • All dataset file-header comments (golden-answer verification discipline, benchmark container constraints, risk-level taxonomy).
  • // Stubs: the db module is mocked at its function boundary (drizzle generates the SQL, so statement-level stubbing would couple tests to its internals). (admin.test.ts) — the banner separators around it were removed, the rationale kept.
  • // Honestly models ON CONFLICT WHERE (failed-only), onConflictDoNothing, INSERT...SELECT...WHERE NOT EXISTS charge guards, and post-batch reads. (profiles.test.ts).
  • // Additional taxonomy-route coverage to keep every pair at 10+ cases (decider-cases.ts) — carries a dataset-count invariant.
  • All D1 bound-variable-ceiling rationales, production-incident notes, quota/charge semantics, no-clobber guard explanations, and mock-limitation comments throughout db.ts, run.ts, profiles.test.ts, and the tests.

No suppressions (eslint-disable, @ts-ignore, coverage ignores) were touched; none appeared in the removed blocks.

Follow-up refactor candidates

None. No deleted comment was load-bearing for understanding the code.

Validation performed

  • pnpm --filter auto-routing-benchmark typecheck — clean
  • pnpm --filter auto-routing-benchmark lint — 0 warnings, 0 errors
  • pnpm --filter auto-routing-benchmark test — 25 files, 290 tests passed
  • oxfmt --check on all six edited files — formatting correct
  • Diff reviewed line by line: only comment lines and directly resulting blank-line changes; every removed line confirmed to be a banner separator or a banner title restating adjacent declarations

@kilo-code-bot kilo-code-bot Bot added the janitor Automated dead-code/duplication cleanup label Sep 23, 2026
@kilo-code-bot
kilo-code-bot Bot enabled auto-merge (squash) September 23, 2026 08:03
@kilo-code-bot

kilo-code-bot Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor Author

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Comment-only cleanup: every removed line is a // banner/separator or a directly resulting blank line, and no executable code, test assertion, or load-bearing comment was deleted.

Files Reviewed (6 files)
  • services/auto-routing-benchmark/src/admin.test.ts
  • services/auto-routing-benchmark/src/datasets/classifier-cases.ts
  • services/auto-routing-benchmark/src/datasets/decider-cases.ts
  • services/auto-routing-benchmark/src/db.test.ts
  • services/auto-routing-benchmark/src/db.ts
  • services/auto-routing-benchmark/src/profiles.test.ts

Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

janitor Automated dead-code/duplication cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant