Repository navigation
(janitor/comments) Remove section banner comments in auto-routing-benchmark - #6633
Merged
Merged
Conversation
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Comment-only cleanup: every removed line is a Files Reviewed (6 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
pandemicsyn
approved these changes
Sep 25, 2026
kilo-code-bot
Bot
deleted the
janitor/comments-auto-routing-benchmark
branch
September 25, 2026 15:21
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package or topic area cleaned
services/auto-routing-benchmark(auto-routing benchmark service)Files touched
src/datasets/decider-cases.tssrc/datasets/classifier-cases.tssrc/db.tssrc/admin.test.tssrc/profiles.test.tssrc/db.test.tsTotal: 193 comment lines removed (plus 25 blank lines that directly resulted), 218 deletions, 0 insertions.
Categories of noise removed
// ------dashed separator pair in the package (76 blocks).taskType/subtaskTypefields of the cases directly below and the<taskType>-<subtype>-<topic>id convention; test banners ("Setup", "Auth guard", "GET /admin/config", "mapRunRow", "lookupProfileStatuses") duplicating the immediately followingdescribe(...)name; production banners ("Row mapping helpers", "Config", "Case results", "Model summaries", "Classifier winner") labeling groups whose function names already say so. Thedb.test.ts"mapSummaryRow" banner was also stale — it sat abovedescribe('variant storage helpers').Important comments intentionally retained
// Stubs: the db module is mocked at its function boundary (drizzle generates the SQL, so statement-level stubbing would couple tests to its internals).(admin.test.ts) — the banner separators around it were removed, the rationale kept.// Honestly models ON CONFLICT WHERE (failed-only), onConflictDoNothing, INSERT...SELECT...WHERE NOT EXISTS charge guards, and post-batch reads.(profiles.test.ts).// Additional taxonomy-route coverage to keep every pair at 10+ cases(decider-cases.ts) — carries a dataset-count invariant.db.ts,run.ts,profiles.test.ts, and the tests.No suppressions (
eslint-disable,@ts-ignore, coverage ignores) were touched; none appeared in the removed blocks.Follow-up refactor candidates
None. No deleted comment was load-bearing for understanding the code.
Validation performed
pnpm --filter auto-routing-benchmark typecheck— cleanpnpm --filter auto-routing-benchmark lint— 0 warnings, 0 errorspnpm --filter auto-routing-benchmark test— 25 files, 290 tests passedoxfmt --checkon all six edited files — formatting correct