Repository navigation
fix(mobile): group Sentry issues by a stable network fingerprint - #6619
Merged
Merged
Conversation
iscekic
marked this pull request as draft
September 23, 2026 05:04
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous Review Summaries (2 snapshots, latest commit 16f572b)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 16f572b)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryBatched tRPC failures still key on the Overview
Issue Details (click to expand)WARNING
Files Reviewed (6 files)
Fix these issues in Kilo Cloud Previous review (commit 11bf868)Status: 2 Issues Found | Recommendation: Address before merge Executive SummaryThe fingerprint policy correctly fixes the reported port, worktree-path, and 401-vs-412 grouping cases; both findings are low-severity pattern/test issues in the new fallback fingerprint path. Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (6 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
iscekic
added a commit
that referenced
this pull request
Sep 23, 2026
iscekic
force-pushed
the
kwf/req-fingerprint-b12f
branch
from
September 23, 2026 06:25
9ee0098 to
16f572b
Compare
iscekic
marked this pull request as ready for review
September 23, 2026 06:40
iscekic
marked this pull request as draft
September 23, 2026 07:01
iscekic
force-pushed
the
kwf/req-fingerprint-b12f
branch
from
September 23, 2026 07:50
54895b2 to
63fb296
Compare
iscekic
marked this pull request as ready for review
September 23, 2026 08:02
eshurakov
approved these changes
Sep 23, 2026
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Scope#captureException.Changelog for maintainers
http.<status>when a status is set, else the tRPC code, else the transport outcome;statusClassis removed.scrubEventfills a fingerprint only when none is set: the exception class plus the message with URL origins, absolute paths,host:port, and query strings removed.host:portpattern is anchored, so a long message cannot makebeforeSendquadratic.ErrortRPC body now rides in the newnetwork.bodycontext, whichscrubEventtoken-scrubs;captureExceptionalways receives a realErrornamedNetworkError.contexts[error.name]becauseextraErrorDataIntegrationreplaces that key with{}beforebeforeSendruns.network.bodycontract first; the reporter opts out ofmax-linesto keep its helpers together.E2E proof
[e1]is a host-only unit scenario (this host has no device tool); log filechecks.log:Owner request
Open findings (not fixed here)