Skip to content

fix(mobile): show repo-relative patch file names in agent transcript - #6610

Merged
iscekic merged 1 commit into
mainfrom
kwf/explorer-3-visual-defects-on-android-the-updated-1-file-l-f55ef-5e81
Sep 23, 2026
Merged

iscekic merged 1 commit into
mainfrom
kwf/explorer-3-visual-defects-on-android-the-updated-1-file-l-f55ef-5e81

Conversation

@iscekic

@iscekic iscekic commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Changelog for users

  • Changed-file rows in the agent transcript show the repo-relative path instead of the workspace path with its session or worktree IDs.
  • Both the "Updated 2 files" and "Updated 1 file" blocks list readable file names.
  • A long path truncates in the middle, so the file name at the end stays visible.

Changelog for maintainers

  • apps/mobile/src/components/agents/part-renderer.tsx:37 — accepted: the prefix regex matched only sessions/, so worktree-backed sessions kept their full /workspace/.../worktrees/<id>/ path. The regex now also matches worktrees, and unit tests cover the worktree root.
  • patchPartFileLabel strips the cloud-agent workspace prefix, with an optional org segment, for both session and worktree roots.
  • Patch file rows render with numberOfLines={1} and ellipsizeMode="middle", keeping the trailing file name when space runs out.
  • Review hints: the prefix regex and its workspace-root list are the risky parts; start with apps/mobile/src/components/agents/part-renderer.tsx and the workspace layout constants. The device captures kept above and the device logs appended below replace the earlier per-scenario capture notes and the earlier "not proved live" findings. Those logs record the three runs passing on the Android emulator; middle-ellipsis rendering and header line wrapping remain visual checks.
  • Unit tests cover absolute, nested, org-scoped, worktree, and non-workspace paths, plus the single-line middle ellipsis.
  • session-message-queued — accepted: absolute workspace paths no longer surface; the device run read "Updated 1 file" then "README.md" with zero /workspace/ text.
  • session-working — accepted: every patch row showed repo-relative names, including a patch written at the workspace-root absolute path.
  • session-preparing — accepted, no change in this diff: the header no longer paints the raw New session - <ISO> placeholder; the device run showed the fallback title only.

E2E proof

Owner request

Surface: mobile-app

Explorer finding: 3 visual defects on android: The "Updated 1 file" line truncates befo; 27.356Z".; The "Updated 2 files" and "Updated 1 fil

The user-agent explorer found these 3 while using the app like a user. They are one kind of defect on one platform, so they are ONE item: the pull request must fix and prove every one of them.
One must-run scenario per finding: the plan needs 3 musts, one for each finding below.
The explorer never edits product code.

Evidence (from the device runs):

--- Finding 1 of 3: session-message-queued: The "Updated 1 file" line truncates before the file name, so the visible text is almost entirely the session UUID ("/workspace/a7e4d40b-c28c-4df1-9a1e-f88e7eb467f1/sessions/W…").
Flow: session-message-queued
Found on revision: f2181ae
Repro:

  1. set this state first: back; relaunch; credits 20; reviews 3; org; battery 15 discharging; uimode night; home; resume; key back; the device in dark mode
  2. open the app on emulator-5602
  3. reach session-message-queued
  4. the capture shows the defect named below
    Observed: The "Updated 1 file" line truncates before the file name, so the visible text is almost entirely the session UUID ("/workspace/a7e4d40b-c28c-4df1-9a1e-f88e7eb467f1/sessions/W…").
    Expected: the screen renders without this defect

--- Finding 2 of 3: session-preparing: The header title is the raw machine timestamp "New session - 2026-09-22T22:18:27.356Z", which wraps mid-string so the second line begins "T22:18:27.356Z".
Flow: session-preparing
Found on revision: f2181ae
Repro:

  1. set this state first: back; relaunch; credits 20; reviews 3; org; battery 15 discharging; uimode night; home; resume; key back; the device in dark mode
  2. open the app on emulator-5602
  3. reach session-preparing
  4. the capture shows the defect named below
    Observed: The header title is the raw machine timestamp "New session - 2026-09-22T22:18:27.356Z", which wraps mid-string so the second line begins "T22:18:27.356Z".
    Expected: the screen renders without this defect

--- Finding 3 of 3: session-working: The "Updated 2 files" and "Updated 1 file" lines both truncate mid-path with "…" before any file name, leaving the session UUID as the readable text.
Flow: session-working
Found on revision: f2181ae
Repro:

  1. set this state first: back; relaunch; credits 20; reviews 3; org; battery 15 discharging; uimode night; home; resume; key back; the device in dark mode
  2. open the app on emulator-5602
  3. reach session-working
  4. the capture shows the defect named below
    Observed: The "Updated 2 files" and "Updated 1 file" lines both truncate mid-path with "…" before any file name, leaving the session UUID as the readable text.
    Expected: the screen renders without this defect

E2E proof — log excerpts

[e1] finding 2 (session-preparing) -> pass :: android: e1-scene.log line 1 'SCENE e1 OK' and digest line 5 'android.widget.Button Rename session: Session tappable [111,84][883,277]' show the header fallback title, and the step 'absent /New session - [0-9]{4}-[0-9]{2}-[0-9]{2}T/' passed (no such line in the digest).
[e2] findings 1 & 3 (session-message-queued / session-working) -> pass :: android: e2-filelabel.log line 1 'SCENE e2 OK' and digest lines 34-35 'android.widget.TextView Updated 1 file' + 'android.widget.TextView src/routes/about/+page.svelte' (line 36 also 'src/routes/+page.svelte') show repo-relative labels; the 'absent /workspace/[0-9a-fA-F-]{8,}/sessions/' step passed and no /workspace/ text appears in the digest — the changed code proves the fix.
[e3] finding 3 (session-working) -> pass :: android: e3-scene.log line 1 'SCENE e3 OK' and digest line 5 'android.widget.Button Rename session: Session tappable [111,84][883,277]', with the 'absent /New session - <ISO>/' step passing.

Comment thread apps/mobile/src/components/agents/part-renderer.tsx Outdated
@kilo-code-bot

kilo-code-bot Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The incremental change widens the workspace-prefix regex to also strip /workspace/<org?>/<userId>/worktrees/<worktreeId>/ roots, resolving the previously reported gap; the label stripping and middle-ellipsis rendering remain correct, and the added unit tests cover the worktree, org-scoped, comment, and list truncation cases.

Files Reviewed (2 files)
  • apps/mobile/src/components/agents/part-renderer.tsx
  • apps/mobile/src/components/agents/part-renderer.test.ts
Previous Review Summary (commit aedad6c)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit aedad6c)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The patch-path label now strips the session workspace prefix and middle-ellipsizes the row; the only gap is that the prefix regex does not cover worktree workspace roots.

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
apps/mobile/src/components/agents/part-renderer.tsx 37 The workspace prefix regex matches only sessions/, so worktree-backed sessions (/workspace/<org?>/<user>/worktrees/<id>) still render their absolute path.
Files Reviewed (2 files)
  • apps/mobile/src/components/agents/part-renderer.tsx - 1 issue
  • apps/mobile/src/components/agents/part-renderer.test.ts - 0 issues

Fix these issues in Kilo Cloud


Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@iscekic
iscekic marked this pull request as draft September 23, 2026 03:23
@iscekic
iscekic force-pushed the kwf/explorer-3-visual-defects-on-android-the-updated-1-file-l-f55ef-5e81 branch from 3b0967e to efa1198 Compare September 23, 2026 03:58
@iscekic
iscekic marked this pull request as ready for review September 23, 2026 04:20
@iscekic iscekic added the human-ready The PR is ready for human review. label Sep 23, 2026
@iscekic iscekic self-assigned this Sep 23, 2026
@iscekic
iscekic merged commit f4f297c into main Sep 23, 2026
29 checks passed
@iscekic
iscekic deleted the kwf/explorer-3-visual-defects-on-android-the-updated-1-file-l-f55ef-5e81 branch September 23, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

human-ready The PR is ready for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants