Repository navigation
fix(mobile): hide default session titles, state failures once, and shorten model-chip copy - #6594
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryRe-reviewed the full diff at HEAD Files Reviewed (24 files)
Previous Review Summaries (6 snapshots, latest commit f61b6af)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit f61b6af)Status: No Issues Found | Recommendation: Merge Executive SummaryRe-reviewed the full PR diff at HEAD Files Reviewed (26 files)
Previous review (commit 5e955db)Status: No Issues Found | Recommendation: Merge Executive SummaryRe-reviewed the incremental changes at HEAD 5e955db: both session rows now seed the rename field and the iOS prompt with Files Reviewed (5 files)
All previously raised findings in the 25-file diff were accepted and fixed in the current HEAD; the files not changed since the last review were not re-analyzed. Previous review (commit 93d95ff)Status: No Issues Found | Recommendation: Merge Executive SummaryReviewed the full 25-file mobile diff at HEAD 93d95ff; no unresolved issues remain in the changed code. Files Reviewed (25 files)
Previous review (commit 55b09a7)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (27 files)
Fix these issues in Kilo Cloud Note: runtime tests were not executed (dependencies unavailable), so findings were verified by reading current HEAD Previous review (commit 4c7736f)Status: No Issues Found | Recommendation: Merge Reviewed the fix commit on top of Files Reviewed (14 changed since previous review)
Notes: runtime tests were not executed (dependencies not installed); findings verified by reading current HEAD Previous review (commit 050a58a)Status: 4 Issues Found | Recommendation: Address before merge Executive SummaryThe title-fallback refactor is sound, but routing backend-default titles through the untitled fallback makes the iOS rename prompt persist placeholder copy as the real session title. Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (23 files)
Fix these issues in Kilo Cloud Notes: no memory leaks found in the changed pure derivations (no listeners, timers, refs, or caches added). The local Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
036cf1e to
4c7736f
Compare
7e25674 to
55b09a7
Compare
cddd9f5 to
93d95ff
Compare
|
kilo-review — independent audit of the published diff. Status: 1 Issues
|
|
bot: Accepted. Pushed ec23a09 (kwf What changed:
|
ec23a09 to
5e955db
Compare
5e955db to
f61b6af
Compare
…orten model-chip copy #6594
1d65d57 to
0b9a62f
Compare
Changelog for users
New session - 2026-09-20T08:10:35.172Zstamp.New session - <timestamp>string.Changelog for maintainers
apps/mobile/src/components/agents/session-row.tsx:114— accepted: the stored row and the remote row seeded the rename field (and the iOS prompt) withsession.title, so an unnamed session reopened the rawNew session - <ISO>string the row hides. Both now seedsessionDisplayTitle(session.title) ?? '', so an unnamed session opens blank with the "Session name" placeholder, and the unchanged/blank guards keep a no-edit confirm from persisting it. Tests pin the empty seed, the trimmed seed for a named session, and the Android modal's empty initial value.apps/mobile/src/components/agents/session-terminal-error.ts:331— accepted: an agent-execution delivery failure renders the assistant-failure title while its SDK status indicator is the "Message delivery failed" line, so the footer printed "Failed to deliver" under a row already saying "Response failed". The predicate now also matches adeliveryfailure whose title key is the assistant-failure title and whose status copy is the delivery-title line, and keys on the failure title rather than thekind; a test pins it.apps/mobile/src/lib/session-title.ts:20— accepted:displaySessionTitleduplicatedsessionDisplayTitlewithout itstrim(), so padded and whitespace-only titles diverged. The duplicate module and its test are deleted; the session list, detail header, continue-from line, and needs-input notification now importsessionDisplayTitlefromsrc/lib/session-display-title.ts, whose untitled check comes fromisDefaultSessionTitlein the shared session-ingest-contracts package instead of a local regex copy.selectMessageFailuremaps anexecutiondelivery failure to the assistant-failure title with a null detail, keeping Retry and copy-to-composer reachable behind the copy action; thedeliveryExecutioncopy key stays in the delivery-reason map but is intentionally unreachable from the row now.resolveModelSelectorLabelpicks the catalog name, else the short display name for a non-provider-aware unmatched reference, else the generic label; the chip renders its result.E2E proof
Owner request
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-e777/e2e-mobile-app/scripted-e1.log