Repository navigation
fix(cloud-agent-next): recover an accepted no-output turn once before failing it - #6582
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryAll five previously reported findings are fixed at HEAD ( Files Reviewed (15 files)
Previous Review Summary (commit 30a0579)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 30a0579)Status: 5 Issues Found | Recommendation: Address before merge Executive SummaryThe control-plane no-output recovery can requeue a turn that was just stopped and re-dispatches without reconciling stored assistant events, while the legacy producer mislabels unrecovered failures as retry exhaustion and drops prompt attachments. Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (11 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
iscekic
marked this pull request as draft
September 22, 2026 19:10
iscekic
force-pushed
the
kwf/28572-e-wrapper-no-output-5187
branch
from
September 22, 2026 22:12
d253a7e to
85c3ce3
Compare
iscekic
marked this pull request as ready for review
September 22, 2026 22:34
eshurakov
approved these changes
Sep 23, 2026
eshurakov
added a commit
that referenced
this pull request
Sep 23, 2026
Reconcile the accepted-turn watchdog with #6582: keep main's inactivity recovery (stored settlement, single re-dispatch, accepted_overdue, cancellation guard) and this branch's socket-blip tolerance plus the follow-up delivery fix. - acceptedRuntimeReadiness owns the ready/blip/stopped split; a blip keeps the accepted row and rearms, only an observed physical stopped is loss - the sync boundary validates a returned ok:false frame before any superseded return and always rethrows in the catch - runtimeFailureHitsAccepted owns which accepted rows a runtime failure affects, including the undefined-wrapper case, at the three scope sites - follow-up delivery falls through to the alarm tail except when the watched row was re-queued for recovery
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
wrapper_no_outputare covered: the accepted-message inactivity timeout inSandboxSession.failOverdueAcceptedMessageand the legacy wrapper no-output watchdog inhandleUnhealthyWrapper.intent(oradmissionSnapshot; legacy rows uselegacyAdmissionConstraints) and re-queued unchanged.recoveryAttemptscounter on the message state bounds both producers to a single automatic recovery.attemptsin the failure payload.E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/28572-e-wrapper-no-output-5187/e2e-backend/e1-first-detection-recovers.log/home/igor_kilocode_ai/.local/share/kwf/sections/28572-e-wrapper-no-output-5187/e2e-backend/e1-2-watchdog-integration.log/home/igor_kilocode_ai/.local/share/kwf/sections/28572-e-wrapper-no-output-5187/e2e-backend/e2-second-detection-terminal.log/home/igor_kilocode_ai/.local/share/kwf/sections/28572-e-wrapper-no-output-5187/e2e-backend/p1-inactivity-integration.logOwner request
Follow-ups (not changed here)
E2E proof — log excerpts