Skip to content

Finish reverting per-repository table - #6558

Merged
intentionally-left-nil merged 3 commits into
mainfrom
drop-repository-customizations
Sep 23, 2026
Merged

intentionally-left-nil merged 3 commits into
mainfrom
drop-repository-customizations

Conversation

@intentionally-left-nil

Copy link
Copy Markdown
Contributor

This finishes the cleanup of the never-deployed per-repo code

Summary

Verification

The table is empty on production, so there is nothing to save

  • [ ]

Visual Changes

Before After

Reviewer Notes

@kilo-code-bot

kilo-code-bot Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The PR cleanly finishes reverting the never-deployed per-repository customization feature: the repository_customizations table, RepositoryReviewMode enum, and related tests/types are removed, and no remaining application code references them.

Files Reviewed (6 files)
  • packages/db/src/migrations/0255_drop_repository_customizations.sql
  • packages/db/src/migrations/meta/0255_snapshot.json
  • packages/db/src/migrations/meta/_journal.json
  • packages/db/src/schema-types.ts
  • packages/db/src/schema.test.ts
  • packages/db/src/schema.ts
Verification Notes
  • No non-migration references to repository_customizations, RepositoryReviewMode, or bot_mention_model_slug remain in apps/, services/, or packages/db/src, so the DROP TABLE ... CASCADE cannot break running application code.
  • The pr_review_mode occurrences that remain live under platform_integrations.metadata (JSON key), not the dropped table column.
  • enumCheck, unique, and withPlatformAccessTokenTestData helpers are still used elsewhere, so no unused-import/lint fallout.
  • The SCHEMA_CHECK_ENUMS registry entry and its test expectation were removed consistently in schema.ts and schema.test.ts.
  • Snapshot diff between 0254 and 0255 is exactly the removal of public.repository_customizations plus the expected id/prevId chain update; no schema drift.

Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@intentionally-left-nil
intentionally-left-nil enabled auto-merge (squash) September 23, 2026 09:46
@intentionally-left-nil
intentionally-left-nil merged commit e1b2994 into main Sep 23, 2026
56 checks passed
@intentionally-left-nil
intentionally-left-nil deleted the drop-repository-customizations branch September 23, 2026 10:00
iscekic added a commit that referenced this pull request Sep 23, 2026
The merge that brought the Live Activity migrations onto main (bdd0a95)
resolved the `_journal.json` and `0255_snapshot.json` conflicts, but left
`0256_snapshot.json` stale. It still recorded `repository_customizations`,
which #6558 had dropped, so `drizzle generate` emitted a spurious
`DROP TABLE "repository_customizations" CASCADE;` against a table that no
longer exists.

Also renumber the two Live Activity migrations so each tag prefix matches
its journal idx, and rebuild the tail snapshots to match each migration
state. The journal `when` values are unchanged, so already-applied
migrations are not re-run.

- 0255_snapshot.json: state after DROP repository_customizations
- 0256_snapshot.json: state after ADD COLUMN superseded_at
- 0257_snapshot.json: state after the partial unique index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants