Repository navigation
fix(mobile): centre quick-tour eyebrow and keep answer placeholder legible - #6535
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryRe-verified the two production edits (quick-tour eyebrow centring, active answer-field placeholder colour) and their four test companions against current HEAD; both edits key off the same state that drives the fill, and the new tests assert reachable behaviour. Files Reviewed (6 files)
Previous Review Summary (commit 4bdfe16)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 4bdfe16)Status: No Issues Found | Recommendation: Merge Executive SummaryReviewed the two production edits (quick-tour eyebrow centring and active answer-field placeholder colour) plus four accompanying test files; the changes are correct, scoped, and consistently tested. Files Reviewed (6 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
d1405b3 to
8616e7e
Compare
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
Changelog for users
Changelog for maintainers
apps/mobile/src/components/tour/tour-screen.tsx— Finding 3 accepted: the modal tour header now passescenterTitle, so the eyebrow centres with the centred fork body;tour-screen.mounted.test.tsxassertscenterTitle: true.apps/mobile/src/components/agents/question-card.tsx— Finding 10 accepted: the custom answer field'splaceholderTextColorfollows the fill (primaryForegroundwhen the field is active,mutedForegroundotherwise);question-card.mounted.test.tsxpins both colours.apps/mobile/src/components/agents/model-picker-content.mounted.test.tsx— Finding 5 rejected: the row for the bridge'scurrentValuealready carriesselectedand renders the trailing Check; the new test asserts exactly the bridged id is selected.apps/mobile/src/components/consent/consent-card.mounted.test.tsx— Finding 2 rejected: the privacy sentence is the last child of theScrollViewand the pinned actions are a following sibling, not an overlay; the new test asserts the line is inside the scroller and the accept button is outside it.isCustomActiveflag that drives the fill, so the two cannot drift.E2E proof
The iOS scenario did not complete. Scenario e1 (the multilingual Preferences screen) was skipped because the simulator never reached a signed-in state; without it the Preferences screen was unreachable, so no accessibility digest, hierarchy or behaviour log was captured. No product code was changed.
Owner request
--- shard 2 ---
VERDICT {"verdict":"passed","scenarios":[{"name":"e2 …[truncated]
VERDICT {"verdict":"passed","scenarios":[{"name":"e1","result":"pass","evidence":"evidence/e1-voiceover.log","note":"ios Home a11y tree (130 elements, 14 human labels) has no raw SF Symbol name and no developer-tool button; the floating-button look is