Repository navigation
fix(mobile): correct session title, discussion empty state, and narrow consent layouts - #6514
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThis commit reworks mobile session-title/rename display, the PR discussion filtered-empty state, the narrow device-auth consent layout, Expo Router Files Reviewed (24 files)
Verified in the changed lines: Previous Review Summary (commit 8ef6ed1)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 8ef6ed1)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (28 files)
Verified and correct in the changed lines: Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
536373d to
eed7910
Compare
…w consent layouts #6514
47cc5d6 to
0720610
Compare
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
…-primary-button-ce5027-78b8
…-primary-button-ce5027-78b8
Changelog for users
New session - <timestamp>placeholder.Changelog for maintainers
displaySessionTitle(shared through the SDK'sisDefaultSessionTitle) treats blank and ISO-placeholder titles as untitled;SESSION_TITLE_MAX_LENGTH(200) mirrors the server rename cap.reserveTitleSpacealready holds; the previous one-line clamp is removed.PrReviewDiscussionListtakes an optionalemptyStateand renders it when the blocked/muted filter empties the loaded page; the load-more and retry footer stay mounted.EmptyStateit renders for an empty discussion; the copy stays on one surface.smand Sign out self-aligns; check the app-mode card at phone width.useDestructiveConfirm(iOS native alert, Android in-app dialog); profile behavior is unchanged.Href, and the case-guard allowlist drops a duplicate passkey entry; both are type- and test-only.E2E proof
Owner request
[e1] Explorer finding: 10 visual defects on android: The primary 'بدء الجلسة' button is clipp; The prompt field renders overlapping, su; The session title in the header wraps mi (+7 more) — android emulator-5554: the shipped 2-step replay MISSed from Home (scripted-e1.log), so the parked steps were edited to navigate and re-run — 'SCENE e1 OK' in e1-live-scene.log, and the same-run digest e1-detail.log shows the header label 'android.widget.TextView KILO-ORG/CLOUD tappable [111,88][577,125]' on one line with 'android.widget.Button Submit review tappable [728,95][1043,189]' and its label 'android.widget.TextView Submit review tappable [806,119][1016,165]' inside the 1080x2400 screen (findings 7/8/10 clean at default font/zoom; visual capture e1-detail.png); also proved on this…
[e1] Explorer finding: 10 visual defects on android: The primary 'بدء الجلسة' button is clipp; The prompt field renders overlapping, su; The session title in the header wraps mi (+7 more)
Open findings (not fixed here)