fix(mobile): keep repository connect button labels on one line

[iscekic]

Changelog for users

• In the new-session repository picker, the "Open GitHub", "Open GitLab" and "Open Bitbucket" buttons keep their labels on one line instead of wrapping to two.
• A label too long for its button now ellipsizes at the tail; screen readers still announce the full text.

Changelog for maintainers

• The connect action label in the new-session repository section is capped at one line, matching how the segmented control keeps its options single-line (explorer captures new-session-filled and new-session-kb-down both showed the wrap).
• A colocated test holds every connect action label to one line: Open GitHub, Open GitLab, Open Bitbucket, and the selected-provider action.
• The session filter button accepts a per-side hitSlop override; the agents header now states both controls' facing slops, so the two touch regions meet inside the row gap instead of overlapping.
• The destructive-confirmation platform choice moved into lib/destructive-confirm-platform.ts; the Profile screen no longer reads Platform.OS, keeping the screen-insets alignment path platform-free. Android still shows the in-app dialog and iOS the native alert, so behavior is unchanged.
• The tabs layout mounted test is renamed off the _layout.* name so Expo Router's typed-routes walk no longer drops the (tabs) subtree.
• Test-only repairs: mounted suites stub safe-area insets and the Skeleton primitive, and duplicate passkey-client entries were removed from the case-guard allowlist.
• Review first the one-line label and the agents-header hit-slop math; both affect layout and touch targets, so check large font scales and long locales.

Owner request

Explorer finding: 10 visual defects on android: The bottom-nav labels break mid-word int; The runtime-error state renders as a ful; the Email Address field's focus ring and (+7 more)

The user-agent explorer found these 10 while using the app like a user. They are one kind of defect on one platform, so they are ONE item: the pull request must fix and prove every one of them.
One must-run scenario per finding: the plan needs 10 musts, one for each finding below.
The explorer never edits product code.

Evidence (from the device runs):

--- Finding 1 of 10: app-home-dark-small: The bottom-nav labels break mid-word into two lines ('Hom e', 'Upda tes', 'Settin gs'), leaving the navigation unreadable at this width.
Flow: app-home-dark-small
Found on revision: f2181ae
Repro:

1. set this state first: uimode night; battery 9 discharging; size 480x1000; density 480; relaunch; back; deeplink kiloapp://home; the device in dark mode
2. open the app on emulator-5554
3. reach app-home-dark-small
4. the capture shows the defect named below
   Observed: The bottom-nav labels break mid-word into two lines ('Hom e', 'Upda tes', 'Settin gs'), leaving the navigation unreadable at this width.
   Expected: the screen renders without this defect

--- Finding 2 of 10: app-runtime-error: The runtime-error state renders as a fully blank black frame with no message, icon, or next action, so the failure looks like a crash rather than a designed error screen.
Flow: app-runtime-error
Found on revision: fd04ca1
Repro:

1. set this state first: account e2e-mobile-cloud-android@example.com signed in via emailed code, $10 credits, a second organization, 4 Code Reviewer pull requests, battery 15% discharging, device portrait.
2. open the app on emulator-5554
3. reach the screen the capture names (app-runtime-error)
4. the capture shows the defect named below
   Observed: The runtime-error state renders as a fully blank black frame with no message, icon, or next action, so the failure looks like a crash rather than a designed error screen.
   Expected: the screen renders without this defect

--- Finding 3 of 10: dev-login-typed2: The dev-login card overflows the viewport to the right: the Email Address field's focus ring and the Sign In button are cut off at the right screen edge while a 30px margin is visible on the left, and the same right-edge cut clips the card divider and label text in the other dev-login captures.
Flow: dev-login-typed2
Found on revision: d923ec3
Repro:

1. set this state first: the device in dark mode
2. open the app on emulator-5554
3. reach the screen the capture names (dev-login-typed2)
4. the capture shows the defect named below
   Observed: The dev-login card overflows the viewport to the right: the Email Address field's focus ring and the Sign In button are cut off at the right screen edge while a 30px margin is visible on the left, and the same right-edge cut clips the card divider and label text in the other dev-login captures.
   Expected: the screen renders without this defect

--- Finding 4 of 10: github-connect-browser: The GitHub connect browser view is a blank white page with no sign-in UI, content or progress indicator, so the repository-connect screen never appears.
Flow: github-connect-browser
Found on revision: 59ef790
Repro:

1. set this state first: true first run (app data wiped) signed in as brand-new e2e-firstrun-1789801978@example.com with $10 credits, 3 seeded Code Reviewer pull requests, membership in a second organization; no GitHub/GitLab linked, no repositories, no sessions; device portrait, system day mode.
2. open the app on emulator-5554
3. reach the screen the capture names (github-connect-browser)
4. the capture shows the defect named below
   Observed: The GitHub connect browser view is a blank white page with no sign-in UI, content or progress indicator, so the repository-connect screen never appears.
   Expected: the screen renders without this defect

--- Finding 5 of 10: github-signin-deadend: The whole screen renders as a blank white page with the app's own chrome ("SEE ALL" top-right, "HOME" bottom-left) faintly white-on-white, leaving no readable content or affordance.
Flow: github-signin-deadend
Found on revision: 25e16c1
Repro:

1. set this state first: brand-new account e2e-empty-1789774546@example.com signed in via emailed code, $10 credits, a second organization to switch to, 3 Code Reviewer pull requests, system font scale 1.5, device portrait.
2. open the app on emulator-5554
3. reach the screen the capture names (github-signin-deadend)
4. the capture shows the defect named below
   Observed: The whole screen renders as a blank white page with the app's own chrome ("SEE ALL" top-right, "HOME" bottom-left) faintly white-on-white, leaving no readable content or affordance.
   Expected: the screen renders without this defect

--- Finding 6 of 10: manual-review-submitted: The error toast text is clipped at the bottom edge, cutting off the last line of the message mid-glyph.
Flow: manual-review-submitted
Found on revision: 9d53b25
Repro:

1. set this state first: account e2e-mobile-cloud-android@example.com with $10 credits, one top-level session permission (ses_f4a82ebf6ffe4w4712QAzyIJlj), Code Reviewer seeded with 3 pull requests whose checks are success, a second organization to switch to, system dark mode, font scale 1.5, battery 15% discharging, device portrait.
2. open the app on emulator-5554
3. reach the screen the capture names (manual-review-submitted)
4. the capture shows the defect named below
   Observed: The error toast text is clipped at the bottom edge, cutting off the last line of the message mid-glyph.
   Expected: the screen renders without this defect

--- Finding 7 of 10: manual-review: The primary action 'بدء المراجعة' is jammed against the bottom tab bar and its label is cut off, so the screen's main call to action is not fully legible.
Flow: manual-review
Found on revision: 59ef790
Repro:

1. set this state first: account e2e-mobile-cloud-android@example.com with $25 credits, a second organization, 4 Code Reviewer pull requests, app UI in Arabic (persisted from a prior run), system day mode, display density 560, portrait, dev build.
2. open the app on emulator-5602
3. reach the screen the capture names (manual-review)
4. the capture shows the defect named below
   Observed: The primary action 'بدء المراجعة' is jammed against the bottom tab bar and its label is cut off, so the screen's main call to action is not fully legible.
   Expected: the screen renders without this defect

--- Finding 8 of 10: new-session-filled: The "Open GitLab" label wraps onto two lines inside a button the same height as the one-line "Open GitHub" sibling, and the same break shows on model-picker.png, model-deepseek-low.png and new-session-no-repo.png.
Flow: new-session-filled
Found on revision: fd04ca1
Repro:

1. set this state first: a wiped install on a brand-new account
2. open the app on emulator-5602
3. reach the screen the capture names (new-session-filled)
4. the capture shows the defect named below
   Observed: The "Open GitLab" label wraps onto two lines inside a button the same height as the one-line "Open GitHub" sibling, and the same break shows on model-picker.png, model-deepseek-low.png and new-session-no-repo.png.
   Expected: the screen renders without this defect

--- Finding 9 of 10: new-session-kb-down: The wide 'Open GitLab' button wraps its two-word label onto two lines ('Open' / 'GitLab') with the icon inline, while every other button on the same screen keeps a single-line label.
Flow: new-session-kb-down
Found on revision: fb5e67d
Repro:

1. set this state first: wipe; uimode day; density 240; battery 100 charging; rotate portrait; relaunch; resume; credits 10; the device in light mode
2. open the app on emulator-5554
3. reach new-session-kb-down
4. the capture shows the defect named below
   Observed: The wide 'Open GitLab' button wraps its two-word label onto two lines ('Open' / 'GitLab') with the icon inline, while every other button on the same screen keeps a single-line label.
   Expected: the screen renders without this defect

--- Finding 10 of 10: new-task-bottom: "Commit and push" wraps onto two lines inside the segmented control while "Leave changes" stays on one, so the two segments have unequal height and weight.
Flow: new-task-bottom
Found on revision: fd04ca1
Repro:

1. set this state first: account e2e-mobile-cloud-android@example.com, $10 credits, 3 Code Reviewer pull requests, one top-level busy session (ses_f488ff9c9ffefhXjlZMDy7Ix8y), display 720x1600, day mode, font 1.0, portrait, event-service down.
2. open the app on emulator-5554
3. reach the screen the capture names (new-task-bottom)
4. the capture shows the defect named below
   Observed: "Commit and push" wraps onto two lines inside the segmented control while "Leave changes" stays on one, so the two segments have unequal height and weight.
   Expected: the screen renders without this defect

Production record (automatic, 2026-09-21):

Production record for ses_f4a82ebf6ffe4w4712QAzyIJlj

Axiom, last 72 h

No line carries this term in: vercel, cloudflare-logpush, supabase-production.

The session row, read replica

No row in cli_sessions_v2 carries ses_f4a82ebf6ffe4w4712QAzyIJlj.

Log archives, R2 kilocode-sessions

NOT READ: R2 keys are indexed by the agent id, not the session id; take the agent_* from the worker logs above and query that.

Sentry, last 72h

No Sentry issue carries this term.

Production record (automatic, 2026-09-21):

Production record for ses_f488ff9c9ffefhXjlZMDy7Ix8y

Axiom, last 72 h

No line carries this term in: vercel, cloudflare-logpush, supabase-production.

The session row, read replica

No row in cli_sessions_v2 carries ses_f488ff9c9ffefhXjlZMDy7Ix8y.

Log archives, R2 kilocode-sessions

NOT READ: R2 keys are indexed by the agent id, not the session id; take the agent_* from the worker logs above and query that.

Sentry, last 72h

No Sentry issue carries this term.

[e4] On a first-run account with no GitHub linked, tap Connect GitHub: a browser with a URL toolbar opens the connect page (never a full-screen blank WebView) — Android emulator-5554, first-run account e2e-empty-explorer-10-visual-defects-on-android-the-bottom-nav-labe-69d0a-9f2b@example.com with its GitHub integration removed (github-disconnect.sh): Home -> Code Reviewer -> GitHub (Not connected) -> Connect GitHub opened Chrome, whose tree in e4-browser.log carries the URL toolbar ('TextView "127.0.0.1:7100"', 'ImageButton "Close tab"', 'ImageButton "Your connection to this site is not secure"', 'ImageButton "Customize and control Google Chrome"') above a rendered page ('TextView "Sign in or create an account to get started"', 'Button "Continue with…

[e1] At 480x1000 density 480 in dark mode, the Home tab renders with each bottom-nav label on one line (ellipsized, never 'Hom e') — Android emulator-5554 at wm size 480x1000 / wm density 480 / night yes: scripted scene 'SCENE e1 OK' and the digest show each tab label node (HOME [15,865][145,909], AGENTS [175,865][305,909], PROFILE [335,865][465,909]) as one 130x44px line inside 162px-tall tab items, so no mid-word wrap; screenshot e1.png left for the visual reviewer.

[e8] On the new task sheet at 720x1600, 'Commit and push' and 'Leave changes' render as equal-height single-line segments — Android emulator-5554 with wm size override 720x1600 (physical density 420, font 1.0): the scene log e8-scene.log reads 'SCENE e8 OK' over a root of 'action_bar_root tappable [0,0][720,1600]' and its final digest shows both segments on the same row with equal height - 'RadioButton Leave changes tappable [46,1077][360,1178]' and 'RadioButton Commit and push tappable [360,1077][674,1178]' (both 101px tall) - each label a one-line 'TextView' 46px tall ('TextView Leave changes tappable [92,1104][313,1150]', 'TextView Commit and push tappable [386,1104][647,1150]'); e8.replay.json holds the replay…

[e2] Trigger a runtime error on a signed-in account: the error screen shows a message, description and Retry immediately, never a blank frame — Android emulator-5604; error state created by a temporary throw in (0_home)/index.tsx (reverted, worktree clean); after dismissing the dev LogBox the app's RuntimeErrorScreen shows text="Something went wrong", text="Please try again." and Button "Retry" bounds=[461,1318][619,1433], quoted from e2-runtime-error.txt.

[e6] On New session, the 'Open GitLab' button keeps its label on one line beside the one-line 'Open GitHub' sibling at 240 and 560 density — Android emulator-5604, provider-less fresh account; density set with adb shell wm density (no harness verb); e6-labels.log carries 'Open GitLab TextView height=27 bounds=[467,1100][572,1127]' at 240 and 'Open GitLab TextView height=62 bounds=[372,1375][610,1437]' at 560, equal to the Open GitHub sibling's text height and button height at both densities.

[e6] On New session, the 'Open GitLab' button keeps its label on one line beside the one-line 'Open GitHub' sibling at 240 and 560 density

[e4] On a first-run account with no GitHub linked, tap Connect GitHub: a browser with a URL toolbar opens the connect page (never a full-screen blank WebView)

[e1] At 480x1000 density 480 in dark mode, the Home tab renders with each bottom-nav label on one line (ellipsized, never 'Hom e')

[e8] On the new task sheet at 720x1600, 'Commit and push' and 'Leave changes' render as equal-height single-line segments

[e2] Trigger a runtime error on a signed-in account: the error screen shows a message, description and Retry immediately, never a blank frame

[e6] On New session, the 'Open GitLab' button keeps its label on one line beside the one-line 'Open GitHub' sibling at 240 and 560 density

[e6] On New session, the 'Open GitLab' button keeps its label on one line beside the one-line 'Open GitHub' sibling at 240 and 560 density

[e3] Open the dev login page in the app's browser at a phone viewport: the Email field and Sign In button sit fully inside the screen with margins on both sides — android emulator-5606: the dev-login page rendered in the app's Chrome (package com.android.chrome, hierarchy width 1080) and the elements sit inside it with equal side margins — e3-devlogin.txt carries the Email Address node [149,865][931,910], the field card [149,865][931,1262], and Sign In [149,1185][931,1262], i.e. 149px margin on each side against a 1080px width; e3.replay.json holds the scripted replay. No visual judgement is made here.

Follow-ups (not changed here)

Open findings (not fixed here)

• not fully verified: some optional checks did not run
• the body has no '## E2E proof' section

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The connect-label wrap fix is already on main, so the remaining diff is a per-side hitSlop prop with an identical default, a comment addition, and a new test suite; none introduce a defect.

Files Reviewed (4 files)

• apps/mobile/src/components/agents/new-session-repository-section.tsx - comment-only change; the one-line label (flex-1 text-center numberOfLines={1}) is already upstream
• apps/mobile/src/components/agents/new-session-repository-section-labels.test.ts - new suite asserting numberOfLines === 1 on each connect action label; passes against the current component
• apps/mobile/src/components/agents/session-filter-button.tsx - adds an optional hitSlop prop defaulting to the existing per-side slop; no behavior change
• apps/mobile/src/components/agents/session-list-header-actions.tsx - passes a per-side FILTER_HIT_SLOP identical to the component default; the row-gap invariant test still holds

Previous Review Summaries (3 snapshots, latest commit 01341aa)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 01341aa)

Status: No Issues Found | Recommendation: Merge

Executive Summary

The rebase resolved the prior conflict and duplicate-mock findings; the remaining changes are a hit-slop override, a duplicate numberOfLines removal, and test repairs, all of which check out against current main behavior.

Files Reviewed (10 files)

• apps/mobile/plugins/branded-splash.test.ts
• apps/mobile/src/app/(app)/(tabs)/tab-bar-keyboard.mounted.test.tsx
• apps/mobile/src/components/agents/new-session-configure-form.test.ts
• apps/mobile/src/components/agents/new-session-repository-section-labels.test.ts
• apps/mobile/src/components/agents/new-session-repository-section.tsx
• apps/mobile/src/components/agents/session-filter-button.tsx
• apps/mobile/src/components/agents/session-list-header-actions.tsx
• apps/mobile/src/components/code-reviewer/manual-review-screen.mounted.test.tsx
• apps/mobile/src/components/ui/segmented-control.tsx
• apps/mobile/src/components/ui/text.rtl-tracking.mounted.test.tsx

Previous review (commit f2b976a)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The branch is now rebased onto main (a800ac2ab) and no longer conflicts; the one remaining item is a duplicate react-native-safe-area-context mock the rebase left in profile-screen.signout.mounted.test.tsx.

Overview

Severity	Count
CRITICAL	0
WARNING	0
SUGGESTION	1

Issue Details (click to expand)

SUGGESTION

File	Line	Issue
apps/mobile/src/components/profile-screen.signout.mounted.test.tsx	51	Adds a second vi.mock('react-native-safe-area-context'); the rebased base already registers one at line 37, so the added mock is dead duplication.

Files Reviewed (8 files)

• apps/mobile/plugins/branded-splash.test.ts - no issues
• apps/mobile/src/app/(app)/(tabs)/tab-bar-keyboard.mounted.test.tsx - renamed from _layout.mounted.test.tsx; no issues
• apps/mobile/src/components/agents/new-session-configure-form.test.ts - previous duplicate-Skeleton finding resolved (one mock remains)
• apps/mobile/src/components/agents/new-session-repository-section-labels.test.ts - new test; no issues
• apps/mobile/src/components/agents/new-session-repository-section.tsx - previous conflict resolved; keeps flex-1 text-center with numberOfLines={1}
• apps/mobile/src/components/agents/session-filter-button.tsx - no issues
• apps/mobile/src/components/agents/session-list-header-actions.tsx - no issues
• apps/mobile/src/components/profile-screen.signout.mounted.test.tsx - 1 issue

The label-wrap fix and the case-guard removal are already on main; this branch no longer conflicts. The remaining duplicate mock is already flagged inline.

Fix these issues in Kilo Cloud

Previous review (commit 1143410)

Status: 3 Issues Found | Recommendation: Address before merge

Executive Summary

The branch is based on an outdated main and is CONFLICTING: new-session-repository-section.tsx and new-session-configure-form.test.ts conflict with equivalent or superset fixes already merged into main.

Overview

Severity	Count
CRITICAL	0
WARNING	2
SUGGESTION	1

Issue Details (click to expand)

WARNING

File	Line	Issue
apps/mobile/src/components/agents/new-session-repository-section.tsx	256	Conflicts with main's superset fix; resolving toward this branch drops flex-1 text-center.
apps/mobile/src/components/agents/new-session-configure-form.test.ts	105	Conflicts with main's identical Skeleton mock.

SUGGESTION

File	Line	Issue
apps/mobile/src/components/profile-screen.signout.mounted.test.tsx	44	Redundant after rebase; main already added the safe-area mock.

Files Reviewed (10 files)

• apps/mobile/src/app/(app)/(tabs)/tab-bar-keyboard.mounted.test.tsx - renamed from _layout.mounted.test.tsx; no issues
• apps/mobile/src/components/agents/new-session-configure-form.test.ts - 1 issue
• apps/mobile/src/components/agents/new-session-repository-section-labels.test.ts - new test; no issues
• apps/mobile/src/components/agents/new-session-repository-section.tsx - 1 issue
• apps/mobile/src/components/agents/session-filter-button.tsx - no issues
• apps/mobile/src/components/agents/session-list-header-actions.tsx - no issues
• apps/mobile/src/components/profile-screen.signout.mounted.test.tsx - 1 issue
• apps/mobile/src/components/profile-screen.tsx - no issues
• apps/mobile/src/lib/case-guard.test.ts - deletions only; identical removal already on main
• apps/mobile/src/lib/destructive-confirm-platform.ts - new file; no issues

main already contains the case-guard.test.ts duplicate-entry removal and the connect-label fix, so most of this branch's non-test changes are duplicated by main; a rebase should shrink the diff considerably. The PR body claims all 10 explorer defects are fixed, but the code only changes the connect-action label wrap plus test and platform-extraction repairs.

Fix these issues in Kilo Cloud

---

_{Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0}

_{Review guidance: REVIEW.md from base branch main}

[iscekic]

kilo-review — independent audit of the published diff.

Status: 1 Issues

File	Line	Issue
apps/mobile/src/components/agents/new-session-repository-section-labels.test.ts	68	The new suite's it.each re-asserts numberOfLines === 1 for openGithub/openGitlab/openBitbucket, which the existing suite already asserts for the same three keys.

[iscekic]

bot: rejected: a suggestion, not a defect. A typed review read this finding as needing no code change before merge; the code stays as is. Say so here if one of them does change behaviour and it will be repaired.

• apps/mobile/src/components/agents/new-session-repository-section-labels.test.ts:68 — The new suite's it.each re-asserts numberOfLines === 1 for openGithub/openGitlab/openBitbucket, which the existing suite already asserts for the same three keys. (p=0.87)

[iscekic]

This description names a scenario the proof did not capture:

• not proved live: At system font scale 1.5, return to the app from the connect flow: the surface shows readable content (home state, loading spinner, or designed error), never a blank frame — reported not_applicable: display geometry is the default (owner, 2026-09-21); a test never changes the zoom or the font size

A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision.