Conversation
Explorer finding: 11-new-task-kbup: The same run-location help text renders the literal backticks around `kilo remote` and `/remote` in the visible copy. The user-agent explorer found this while using the app like a user. One finding per item; the explorer never edits product code. Flow: 11-new-task-kbup Found on revision: fb5e67d Repro: 1. set this state first: uimode day; density 560; battery 88 charging; reviews 4; credits 15; relaunch; back; seed app:github-account e2e-firstrun-1789896598@example.com; rotate landscape; rotate portrait; home; resume; fault nextjs down; fault nextjs up; the device in light mode 2. open the app on emulator-5554 3. reach 11-new-task-kbup, 12-new-task-kbdown 4. the capture shows the defect named below Observed: The same run-location help text renders the literal backticks around `kilo remote` and `/remote` in the visible copy. Expected: the screen renders without this defect Evidence (from the device run): - ~/.local/share/kwf/findings/explorer-11-new-task-kbup-the-same-run-location-help-text-ea813e76/11-new-task-kbup.png - ~/.local/share/kwf/findings/explorer-11-new-task-kbup-the-same-run-location-help-text-ea813e76/12-new-task-kbdown.png
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed all eight changed files of this mobile copy fix (a pure backtick-stripping helper applied at all five run-location call sites, the marker-free English catalog, and the new unit tests); no correctness, security, or memory-leak issues found. Verified statically: every call site wraps its Files Reviewed (8 files)
Reviewed by efficient · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
eshurakov
left a comment
There was a problem hiding this comment.
Approved after a shallow triage pass. No blocking findings.
…cation-help-text-ea813-27b9
…cation-help-text-ea813-27b9
Changelog for users
kilo remoteand/remoteas plain text in every app language.Changelog for maintainers
stripInlineCodeMarkershelper removes backticks at render time and is applied to the five run-location call sites.tour.remoteRunHintresolves through$t(agentChat.newSession.remoteHint), so the tour is covered at its render site.E2E proof
[e2] Open the first-sign-in tour's computer step with no CLI connected: both the empty-state body and the mono start-instructions line show 'kilo remote' / '/remote' with no backticks. — Android emulator-5604; run in Swedish so the diff is exercised — the screen shows the empty-state body 'För att ansluta den, kör kilo remote på din dator.' and the mono line 'Kör kilo remote på din dator, eller /remote i en aktiv CLI-session, för att styra en lokal kilo-process.', with no backtick in any text (e2-tour-computer-step.txt, e2-tour-computer-step.png, e2-tour-computer-step-hierarchy.txt); the default-locale English run confirms the same copy marker-free (e2-tour-computer-step-en.txt, e2-tour-computer-step-en.png), as does the fork step (e2-tour-fork-step.txt). UX observation…
[e1] new-session help line shows kilo remote and /remote without backticks (Urdu) — Urdu new-session digest (e1-scene.log, SCENE e1 OK) renders 'اپنے کمپیوٹر پر kilo remote یا چلتے ہوئے CLI سیشن میں /remote چلائیں۔' under the run-target selector with 0 backticks; screenshot e1.png for the visual reviewer. No UX defect in the digest.
[e3] Run-on picker empty card shows kilo remote without backticks — Run-on picker digest (e3-scene.xml/e3-run-on-empty.log, SCENE e3 OK) shows header 'چلانے کی جگہ', empty title 'کوئی CLI انسٹینس منسلک نہیں', and description 'اپنے کمپیوٹر پر کسی پروجیکٹ میں kilo remote چلائیں۔' with no backticks; screenshot e3.png for the visual reviewer. No UX defect in the digest.
[e2] Open the first-sign-in tour's computer step with no CLI connected: both the empty-state body and the mono start-instructions line show 'kilo remote' / '/remote' with no backticks.
[e2] Open the first-sign-in tour's computer step with no CLI connected: both the empty-state body and the mono start-instructions line show 'kilo remote' / '/remote' with no backticks.
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-11-new-task-kbup-the-same-run-location-help-text-ea813-27b9/e2e-mobile-app/e1-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-11-new-task-kbup-the-same-run-location-help-text-ea813-27b9/e2e-mobile-app/e3-run-on-empty.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-11-new-task-kbup-the-same-run-location-help-text-ea813-27b9/e2e-mobile-app/e2-tour-computer-step.txt/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-11-new-task-kbup-the-same-run-location-help-text-ea813-27b9/e2e-mobile-app/e2-tour-computer-step-hierarchy.txt/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-11-new-task-kbup-the-same-run-location-help-text-ea813-27b9/e2e-mobile-app/e2-tour-computer-step-en.txt/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-11-new-task-kbup-the-same-run-location-help-text-ea813-27b9/e2e-mobile-app/e2-tour-fork-step.txtOwner request
Follow-ups (not changed here)
Open findings (not fixed here)