Repository navigation
fix(mobile): ignore Expo fetch cancellations in network error telemetry - #6307
Merged
Merged
Conversation
Investigate the network-connectivity reports in Sentry and fix them where possible.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the mobile network-telemetry change that classifies Expo Files Reviewed (2 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
pandemicsyn
approved these changes
Sep 18, 2026
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Canceled requests no longer appear as network-connectivity errors in Sentry.
Changelog for maintainers
isAbortErrornow treats Expo'sFetchRequestCanceledExceptionas an abort, alongsideAbortErrorandDOMException.name, oncode(expo-modules-coreCodedError), insidemessage(theFetchErrorwrapper), and one level undercause.createNetworkErrorFetchalready skips reporting aborts, so canceled fetches stop emitting warning-level network events.RequestDeadlineErrortimeout reporting are unchanged.falseand never throws.messagebranch matches the full tokenFetchRequestCanceledException; confirm that cannot hide a real failure.E2E proof
[e1] signed-in agent picker still renders its network-backed model rows after the fetch-wrapper change — android emulator-5554; start state state.sh agent-picker => STATE HIT (e1-state.log), scene 'Run on: Cloud Agent' -> tap 'Auto Efficient' -> assert 'Laguna S 2.1 (free)' => e1.log line 1 "SCENE e1 OK"; live digest line 47 "android.widget.Button Laguna S 2.1 (free), poolside/laguna-s-2.1:free, Free, and Data collected tappable [0,1758][900,1963]", with Nemotron 3 Ultra at line 55 and Nex-N2.5-Pro at line 71; the rows are network-fetched (e1-models-fetch.log line 3993 "GET /api/openrouter/models 200 in 1392ms"). Env fixture: the branch's web server needs CREDIT_CATEGORIES_ENCRYPTION_KEY_V2…
/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-c57cb6e-e385/e2e-backend/backend.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-c57cb6e-e385/e2e-mobile-app/e1.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-c57cb6e-e385/e2e-mobile-app/e1-state.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-c57cb6e-e385/e2e-mobile-app/e1-models-fetch.logOwner request