Repository navigation
Add minimax admin functionality - #6293
Conversation
ac05ee4 to
168282e
Compare
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe test/signature mismatch flagged previously is fixed, but the reduce-inventory dialog copy still tells admins to use a "Pending Key Removal queue" while the UI tab and success toasts name it "Pending Key Rotation". Overview
Issue Details (click to expand)WARNING
Files Reviewed (2 files)
Fix these issues in Kilo Cloud Previous Review Summaries (2 snapshots, latest commit f39096b)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit f39096b)Status: 2 Issues Found | Recommendation: Address before merge Executive SummaryThe latest "linting" commit changed Overview
Issue Details (click to expand)CRITICAL
WARNING
Files Reviewed (8 files)
Fix these issues in Kilo Cloud Previous review (commit 3a00397)Status: No Issues Found | Recommendation: Merge Executive SummaryReviewed the new MiniMax admin swap/reduce flows end to end; the SQL is parameterized, row locking is consistent (subscription row locked before inventory rows in both Files Reviewed (8 files)
Note: the kilocode-landing content/SEO rules and the markdown-image rule supplied in the review prompt do not apply to this PR, which touches no landing pages or Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
4fe9318 to
05d7438
Compare
5058c6e to
238de44
Compare
|
|
||
| describe('reduce inventory copy', () => { | ||
| it('names the plan and available count, and explains the manual provider-side step', () => { | ||
| const dialog = getReduceInventoryDialogCopy('minimax-token-plan-plus', 5); |
There was a problem hiding this comment.
CRITICAL: Tests call getReduceInventoryDialogCopy with the removed availableCount argument
This PR changed getReduceInventoryDialogCopy(planId, availableCount) to getReduceInventoryDialogCopy(planId) and replaced the description, but this test was not updated. getReduceInventoryDialogCopy('minimax-token-plan-plus', 5) fails TypeScript with 'Expected 1 arguments, but got 2', and the assertions below (5 credentials are currently available, Pending Key Rotation, Kilo never contacts the provider) can no longer pass against the new copy. The same stale call and assertions appear at lines 133-134. Update these tests (or restore the richer description) so the suite passes.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
f39096b to
2e27080
Compare
Summary
This adds two new buttons to the coding plan admin page:
Verification
UI looks correct, will verify in prod once changes are deployed
Visual Changes