Repository navigation
fix(mobile): center the guided tour step content vertically - #6229
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe latest commit changes only the explanatory comment on Files Reviewed (1 file)
Validation: static review only in a read-only, non-interactive session; no test, lint, or typecheck command was executed. The changed lines are comment text only, so no runtime or memory-leak risk was introduced. Previous Review Summary (commit 7442b81)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 7442b81)Status: 1 Issue Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Executive SummaryThis is a class-only vertical-centering tweak in the two guided-tour steps, mirrored by mounted-test assertion updates; the single finding is a copy-pasted comment clause in Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (4 files)
Validation: static review only in a read-only, non-interactive session; no test, lint, or typecheck command was executed. The added Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
7442b81 to
e65bab1
Compare
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
Changelog for users
Changelog for maintainers
ForkStepandTourRemoteStepScrollView content containers now usegrow items-center justify-center gap-* px-6 py-6.grow(flex-grow: 1) fills the viewport sojustify-centerdistributes the children; it is a minimum, so taller content scrolls instead of clipping.py-6); the previous top-alignedpt-4first-run rhythm is dropped.CenteredStateis not rendered.E2E proof
[e1] Open the tour (Profile -> Tutorial replay) and land on "Where would you like to run Kilo?": the icon, title, subtitle and the Cloud Agent / Your computer cards sit vertically centred in the band… — android emulator-5554, 1080x2400: the Profile -> Tutorial replay lands on the fork step (SCENE e1 OK, e1-open.log) and e1-tall-hierarchy.xml puts the body ScrollView at [0,218][1080,2203] with the icon box [448,767][632,951] and the last card [55,1441][1025,1654] - 549 px above and 549 px below the block - title [147,988][933,1062], Skip tour [55,2221][1025,2336]; centring appearance is the visual reviewer's. NOTE: the pack's scenario line for e1 is truncated mid-sentence, so the scenario text was taken from the PR description's own E2E proof block.
[e2] On the same fork, tap "Your computer": the icon/title/subtitle block stays centred in the same band while the computer list is loading, after it resolves empty ("No computer connected yet" + Check… — android emulator-5554, 1080x2400: SCENE e2 OK (e2.log) taps Your computer and lands on the empty state 'No computer connected yet' [279,1261][800,1326] + Check again; e2-loading.log (hold from e2-fault-stall.log: 'fault.sh: stalled pids [34092] for 120s') shows the busy Check-again button [374,1593][706,1709]; e2-error.log shows 'Network error. Please try again.' [308,1520][772,1566] + Retry; SCENE e2-recovery OK (e2-recovery.log) shows tap Retry returns to 'No computer connected yet' [279,1261][800,1326]; the title [178,920][903,994] and subtitle [56,1003][1025,1115] are identical in…
[e3] On a short screen or with a large system font, the tour body starts at the top padding and scrolls to the Skip bar: nothing is clipped under the header and the cards are reachable. — android emulator-5554 at wm size 1080x1200: e3-short-entry.log shows title [147,430][933,504] with the second card [55,883][1025,1003] clipped by the viewport, and e3-short-entry-hierarchy.xml puts the body ScrollView at [0,154][1080,1003] below the QUICK TOUR header with the first child icon box at [448,209][632,393], so nothing sits under the header; one swipe up (SCENE e3-short-scrolled OK) moves the title to [147,282][933,356] with both cards [55,494][1025,707] and [55,735][1025,948] fully above Skip tour [55,1021][1025,1136]; wm size restored to 1080x2400 afterwards; scroll appearance is…
/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-e65bab1-2-8889/e2e-mobile-app/e1-open.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-e65bab1-2-8889/e2e-mobile-app/e2-loading.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-e65bab1-2-8889/e2e-mobile-app/e2.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-e65bab1-2-8889/e2e-mobile-app/e2-fault-stall.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-e65bab1-2-8889/e2e-mobile-app/e2-error.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-e65bab1-2-8889/e2e-mobile-app/e2-recovery.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-e65bab1-2-8889/e2e-mobile-app/e2-empty2.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-e65bab1-2-8889/e2e-mobile-app/e3-short-scrolled.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-e65bab1-2-8889/e2e-mobile-app/e3-short-entry.logOwner request